[prev in list] [next in list] [prev in thread] [next in thread] 

List:       postgresql-general
Subject:    Re: [HACKERS] Support for array_remove and array_replace functions
From:       Marco Nenciarini <marco.nenciarini () 2ndquadrant ! it>
Date:       2012-06-30 21:28:28
Message-ID: 4FEF6F7C.2060408 () 2ndquadrant ! it
[Download RAW message or body]

On 30/06/2012 04:16, Alex Hunsaker wrote:
>  
> Hi, I've been reviewing this patch.
> 
> Good documentation, and regression tests. The code looked fine but I
> didn't care for the code duplication between array_replace and
> array_remove so I merged those into a helper function,
> array_replace_internal(). Thoughts?

It looks reasonable.

There was a typo in array_replace which was caught by regression tests.
I've fixed the typo and changed a comment in array_replace_internal.

Patch v3 attached.

Regards,
Marco

-- 
Marco Nenciarini - 2ndQuadrant Italy
PostgreSQL Training, Services and Support
marco.nenciarini@2ndQuadrant.it | www.2ndQuadrant.it

["array-functions-v3.patch.bz2" (application/x-bzip)]

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[prev in list] [next in list] [prev in thread] [next in thread]