[prev in list] [next in list] [prev in thread] [next in thread] 

List:       postgresql-general
Subject:    Re: [HACKERS] "make check" in src/test/isolation is unworkable
From:       Andrew Dunstan <andrew () dunslane ! net>
Date:       2012-02-29 20:08:06
Message-ID: 4F4E85A6.7070906 () dunslane ! net
[Download RAW message or body]



On 02/29/2012 02:33 PM, Peter Eisentraut wrote:
> On sön, 2011-05-08 at 19:35 -0400, Tom Lane wrote:
>> I believe that the "make check" target in src/test/isolation is
>> fundamentally unportable, as is illustrated by the fact that buildfarm
>> member coypu is currently choking on it.  The reason is that the
>> pg_isolation_regress program depends on libpq, and in particular it
>> depends on having an *installed* libpq.  Anyplace where it appears to
>> work, it's because you already installed Postgres, or at least libpq.
> I came across this old issue.  Unless I'm missing something, there is no
> reason why pg_isolation_regress needs to be linked with libpq at all,
> and it works fine without it.  If we removed the libpq link, then it
> would work just like pg_regress and could support "make check".
>
> Apparently, -Wl,--as-needed isn't working too well here.
>
>


I believe we can't rely on it working. If we really don't need libpq 
then why not just filter it out?

cheers

andrew

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
[prev in list] [next in list] [prev in thread] [next in thread]