[prev in list] [next in list] [prev in thread] [next in thread] 

List:       postgresql-general
Subject:    Re: [HACKERS] myProcLocks initialization
From:       Tom Lane <tgl () sss ! pgh ! pa ! us>
Date:       2011-10-31 20:22:45
Message-ID: 8133.1320092565 () sss ! pgh ! pa ! us
[Download RAW message or body]

Simon Riggs <simon@2ndQuadrant.com> writes:
> On Mon, Oct 31, 2011 at 7:54 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>> Revised patch attached.  I think it would be useful to assert this
>> both at process startup time and at process shutdown, since it would
>> really be much nicer to have the process that didn't clean up fail the
>> assertion, rather than the new one that innocently inherited its slot;
>> so the attached patch takes that approach.

> Something stronger than an assertion at shutdown? Run-time test?

There's currently no evidence to suggest this will ever fire at all,
especially not in non-development builds, so an assert seems enough
to me.

			regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
[prev in list] [next in list] [prev in thread] [next in thread]