[prev in list] [next in list] [prev in thread] [next in thread] 

List:       postgresql-general
Subject:    Re: [HACKERS] Review of VS 2010 support patches
From:       Andrew Dunstan <andrew () dunslane ! net>
Date:       2011-07-31 1:25:58
Message-ID: 4E34AF26.1050306 () dunslane ! net
[Download RAW message or body]



On 07/06/2011 08:26 PM, Brar Piening wrote:
> -------- Original Message  --------
> Subject: Re: [HACKERS] Review of VS 2010 support patches
> From: Andrew Dunstan <andrew@dunslane.net>
> To: Brar Piening <brar@gmx.de>
> Date: 06.07.2011 22:58
>
>>> I'll remove my versions from the patch (v9 probably) if those files 
>>> get commited.
>>>
>>
>>
>> I'm just doing some final testing and preparing to commit the new 
>> pgflex and pgbison.
>
>
> The attached patch includes documentation changes and excludes my 
> versions of pgbison.pl and pgflex.pl which have been replaced by 
> Andrews' versions that are already commited.
>
> As before "perltidy_before.patch" has to be applied first and 
> "VS2010v9.patch" second.
>
>

I just started looking at this a bit. One small question: why are we 
using "use base qw(foo);" instead of "use parent qw(foo);" which I 
understand is preferred these days?

cheers

andrew

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
[prev in list] [next in list] [prev in thread] [next in thread]