[prev in list] [next in list] [prev in thread] [next in thread] 

List:       postgresql-general
Subject:    Re: [HACKERS] Please test peer (socket ident) auth on *BSD
From:       Marko Kreen <markokr () gmail ! com>
Date:       2011-05-31 22:30:56
Message-ID: BANLkTi=wHAqZF3PKoUuwfSVtQ=DpFcw=pw () mail ! gmail ! com
[Download RAW message or body]

On Wed, Jun 1, 2011 at 1:03 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Marko Kreen <markokr@gmail.com> writes:
>> My suggestion would be to use getpeereid() everywhere.
>> And just have compat getpeereid() implementation on non-BSD
>> platforms.  This would minimize ifdeffery in core core.
>
> Hm, maybe.  I'd be for this if we had more than two call sites, but
> as things stand I'm not sure it's worth the trouble to set up a src/port
> module for it.

It would remove ~50 lines of low-level code from otherwise
high-level function.  So even with one call site it would be improvement.

If the src/port is trouble, how about putting it as 'static inline' into .h?  :)

-- 
marko

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[prev in list] [next in list] [prev in thread] [next in thread]