[prev in list] [next in list] [prev in thread] [next in thread] 

List:       postgresql-general
Subject:    Re: [HACKERS] improve plpgsql's EXECUTE 'select into' message
From:       Bruce Momjian <bruce () momjian ! us>
Date:       2010-05-31 20:02:51
Message-ID: 201005312002.o4VK2pd16640 () momjian ! us
[Download RAW message or body]

Jaime Casanova wrote:
> Hi,
> 
> while TFM says that we can use EXECUTE 'select ' INTO instead of the
> non implemented EXECUTE 'select ... into ', the message in plpgsql
> fails to say the same thing... seems like a HINT to me

Applied with attached patch.  Thanks.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + None of us is going to be here forever. +


["/rtmp/diff" (/rtmp/diff)]

Index: src/pl/plpgsql/src/pl_exec.c
===================================================================
RCS file: /cvsroot/pgsql/src/pl/plpgsql/src/pl_exec.c,v
retrieving revision 1.257
diff -c -c -r1.257 pl_exec.c
*** src/pl/plpgsql/src/pl_exec.c	14 Apr 2010 23:52:10 -0000	1.257
--- src/pl/plpgsql/src/pl_exec.c	31 May 2010 19:59:45 -0000
***************
*** 3033,3039 ****
  				if (*ptr == 'S' || *ptr == 's')
  					ereport(ERROR,
  							(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
! 					errmsg("EXECUTE of SELECT ... INTO is not implemented")));
  				break;
  			}
  
--- 3033,3040 ----
  				if (*ptr == 'S' || *ptr == 's')
  					ereport(ERROR,
  							(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
! 					errmsg("EXECUTE of SELECT ... INTO is not implemented"),
! 					errhint("You might want to use EXECUTE ... INTO instead.")));
  				break;
  			}
  


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[prev in list] [next in list] [prev in thread] [next in thread]