[prev in list] [next in list] [prev in thread] [next in thread] 

List:       postgresql-general
Subject:    Re: [HACKERS] [COMMITTERS] pgsql: Remove typename from A_Const.
From:       Tom Lane <tgl () sss ! pgh ! pa ! us>
Date:       2008-04-29 20:15:59
Message-ID: 5500.1209500159 () sss ! pgh ! pa ! us
[Download RAW message or body]

Alvaro Herrera <alvherre@commandprompt.com> writes:
> Tom Lane escribió:
>> I'm thinking is that we should get rid of the ::float8 decoration too,
>> and thereby be able to revert some of the ugly code added elsewhere such
>> as guc.c.

> Hmm, I'm not sure but I think the typecast is needed in the guc.c code
> in order to pass the fact that the Const is an Interval.

Yeah, I had just found that out --- it's not so much that we care that
it's an interval, as that the original input might have had typmod
restrictions that need to be applied to the interval value.  Definitely
a kluge to support a corner case ...

Anyway, I'm in the middle of testing removal of the ::float8 cast
--- we can at least simplify parse_type.c's handling of typmods here.
I also see that we can eliminate some manual construction of A_Const's
in gram.y, since makeFloatConst and friends no longer do any unwanted
extra stuff.

			regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
[prev in list] [next in list] [prev in thread] [next in thread]