[prev in list] [next in list] [prev in thread] [next in thread] 

List:       postgis-devel
Subject:    Re: [postgis-devel] Proposal: Adding buffer parameter to	ST_TileEnvelope()
From:       "Regina Obe" <lr () pcorp ! us>
Date:       2019-12-07 18:26:11
Message-ID: 001201d5ad2b$cdeeb5b0$69cc2110$ () pcorp ! us
[Download RAW message or body]

This is a multipart message in MIME format.

[Attachment #2 (multipart/alternative)]
This is a multipart message in MIME format.


I assigned Paul, Raul, Sandro, and Darafei for feedback.

 

I don't have too many opinions about it.  If Raul is fine with it, I'm fine with it \
:)

 

 

Thanks,

Regina

 

From: postgis-devel [mailto:postgis-devel-bounces@lists.osgeo.org] On Behalf Of Yuri \
                Astrakhan
Sent: Saturday, December 7, 2019 12:42 PM
To: PostGIS Development Discussion <postgis-devel@lists.osgeo.org>
Subject: Re: [postgis-devel] Proposal: Adding buffer parameter to ST_TileEnvelope()

 

What should the next steps be to get https://github.com/postgis/postgis/pull/514 \
merged?  Are there any blockers or required TODOs?  Thanks!

                                                                                      \


On Thu, Nov 14, 2019 at 2:29 PM Yuri Astrakhan <yuriastrakhan@gmail.com \
<mailto:yuriastrakhan@gmail.com> > wrote:

How should we grow tiles then with regards to the bounds parameter?  I see two \
approaches:

* bbox longitude (x) is not clipped unless it grows wider than the bounds, in which \
case the result spans the whole bounding box. Latitude (y) is always clipped.

    PROs: makes it possible to use with geometry columns without any extra \
modifications.

    CONs: might cause confusion because the result could be outside of bounds, and \
because it might not match geometries across antimeredian.

* bbox grows up to the bounds, and then gets clipped.

    PROs: all generated bboxes are within the bounds, using it as filter always \
matches real data in the geometry columns.

    CONs: have to manually extend it across antimeredian if needed.

 

I'm inclined to go with the first approach, would that be ok?

 

On Thu, Nov 14, 2019 at 7:58 AM Paul Ramsey <pramsey@cleverelephant.ca \
<mailto:pramsey@cleverelephant.ca> > wrote:

 





On Nov 13, 2019, at 11:35 PM, Yuri Astrakhan <yuriastrakhan@gmail.com \
<mailto:yuriastrakhan@gmail.com> > wrote:

 

Rough implementation PR - https://github.com/postgis/postgis/pull/514

 

I am having some issues with unit tests (too much magic in auto-generated code?), so \
a Postgis guru's help might be needed.

 

One open concern: extending envelope beyond antimeredian. Is this possible? Would a \
bbox from the tile that overflows to the other side of antimeredian match any \
geometries? For example, given two points - one at -179, and the other is at +179 \
(longitude), would they be found with the bbox that goes from -200..-160 ?

 

In geometry they would not match, in geography they would.

 

P





_______________________________________________
postgis-devel mailing list
postgis-devel@lists.osgeo.org <mailto:postgis-devel@lists.osgeo.org> 
https://lists.osgeo.org/mailman/listinfo/postgis-devel

 

_______________________________________________
postgis-devel mailing list
postgis-devel@lists.osgeo.org <mailto:postgis-devel@lists.osgeo.org> 
https://lists.osgeo.org/mailman/listinfo/postgis-devel


[Attachment #5 (text/html)]

<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
	{font-family:Wingdings;
	panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	margin-bottom:.0001pt;
	font-size:12.0pt;
	font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:purple;
	text-decoration:underline;}
span.EmailStyle17
	{mso-style-type:personal-reply;
	font-family:"Calibri",sans-serif;
	color:#1F497D;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-family:"Calibri",sans-serif;}
@page WordSection1
	{size:8.5in 11.0in;
	margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
	{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div \
class=WordSection1><p class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>I assigned \
Paul, Raul, Sandro, and Darafei for feedback.<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p>&nbsp;</o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>I don't have \
too many opinions about it.   If Raul is fine with it, I'm fine with it </span><span \
style='font-size:11.0pt;font-family:Wingdings;color:#1F497D'>J</span><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p>&nbsp;</o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p>&nbsp;</o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Thanks,<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Regina<o:p></o:p></span></p><p \
class=MsoNormal><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p>&nbsp;</o:p></span></p><p \
class=MsoNormal><b><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif'>From:</span></b><span \
style='font-size:11.0pt;font-family:"Calibri",sans-serif'> postgis-devel \
[mailto:postgis-devel-bounces@lists.osgeo.org] <b>On Behalf Of </b>Yuri \
Astrakhan<br><b>Sent:</b> Saturday, December 7, 2019 12:42 PM<br><b>To:</b> PostGIS \
Development Discussion &lt;postgis-devel@lists.osgeo.org&gt;<br><b>Subject:</b> Re: \
[postgis-devel] Proposal: Adding buffer parameter to \
ST_TileEnvelope()<o:p></o:p></span></p><p \
class=MsoNormal><o:p>&nbsp;</o:p></p><div><p class=MsoNormal>What should the next \
steps be to get&nbsp;<a \
href="https://github.com/postgis/postgis/pull/514">https://github.com/postgis/postgis/pull/514</a>&nbsp;merged?&nbsp; \
Are there any blockers or required TODOs?&nbsp; Thanks!<o:p></o:p></p></div><p \
class=MsoNormal><span style='color:#1F497D'>                                          \
</span><o:p></o:p></p><div><div><p class=MsoNormal>On Thu, Nov 14, 2019 at 2:29 PM \
Yuri Astrakhan &lt;<a \
href="mailto:yuriastrakhan@gmail.com">yuriastrakhan@gmail.com</a>&gt; \
wrote:<o:p></o:p></p></div><blockquote style='border:none;border-left:solid #CCCCCC \
1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in'><div><p \
class=MsoNormal>How should we grow tiles then with regards to the bounds \
parameter?&nbsp; I see two approaches:<o:p></o:p></p><div><p class=MsoNormal>* bbox \
longitude (x) is not clipped unless it grows wider than the bounds, in which case the \
result spans the whole bounding box. Latitude (y) is always \
clipped.<o:p></o:p></p></div><div><p class=MsoNormal>&nbsp; &nbsp; PROs: makes it \
possible to use with geometry columns without any extra \
modifications.<o:p></o:p></p></div><div><p class=MsoNormal>&nbsp; &nbsp; CONs: might \
cause confusion because the result could be outside of bounds, and because it might \
not match geometries across&nbsp;antimeredian.<o:p></o:p></p><div><p \
class=MsoNormal>* bbox grows up to the bounds, and then gets \
clipped.<o:p></o:p></p></div><div><p class=MsoNormal>&nbsp; &nbsp; PROs: all \
generated bboxes are within the bounds, using it as filter always matches real data \
in the geometry columns.<o:p></o:p></p></div><div><p class=MsoNormal>&nbsp; &nbsp; \
CONs: have to manually extend it across&nbsp;antimeredian if \
needed.<o:p></o:p></p></div></div><div><p \
class=MsoNormal><o:p>&nbsp;</o:p></p></div><div><p class=MsoNormal>I'm inclined to go \
with the first approach, would that be ok?<o:p></o:p></p></div></div><p \
class=MsoNormal><o:p>&nbsp;</o:p></p><div><div><p class=MsoNormal>On Thu, Nov 14, \
2019 at 7:58 AM Paul Ramsey &lt;<a href="mailto:pramsey@cleverelephant.ca" \
target="_blank">pramsey@cleverelephant.ca</a>&gt; \
wrote:<o:p></o:p></p></div><blockquote style='border:none;border-left:solid #CCCCCC \
1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in'><div><p \
class=MsoNormal><o:p>&nbsp;</o:p></p><div><p \
class=MsoNormal><br><br><o:p></o:p></p><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><div><p class=MsoNormal>On Nov 13, 2019, \
at 11:35 PM, Yuri Astrakhan &lt;<a href="mailto:yuriastrakhan@gmail.com" \
target="_blank">yuriastrakhan@gmail.com</a>&gt; wrote:<o:p></o:p></p></div><p \
class=MsoNormal><o:p>&nbsp;</o:p></p><div><div><div><p class=MsoNormal>Rough \
implementation PR -&nbsp;<a href="https://github.com/postgis/postgis/pull/514" \
target="_blank">https://github.com/postgis/postgis/pull/514</a><o:p></o:p></p></div><div><div><p \
class=MsoNormal><o:p>&nbsp;</o:p></p></div><div><p class=MsoNormal>I am having some \
issues with unit tests (too much magic in auto-generated code?), so a Postgis guru's \
help might be needed.<o:p></o:p></p></div></div><div><p \
class=MsoNormal><o:p>&nbsp;</o:p></p></div><div><p class=MsoNormal>One open concern: \
extending envelope beyond antimeredian. Is this possible? Would a bbox from the tile \
that overflows to the other side of antimeredian match any geometries? For example, \
given two points - one at -179, and the other is at&nbsp;+179 (longitude), would they \
be found with the bbox that goes from -200..-160 \
?<o:p></o:p></p></div></div></div></blockquote><div><p \
class=MsoNormal><o:p>&nbsp;</o:p></p></div><div><p class=MsoNormal>In geometry they \
would not match, in geography they would.<o:p></o:p></p></div><div><p \
class=MsoNormal><o:p>&nbsp;</o:p></p></div><div><p \
class=MsoNormal>P<o:p></o:p></p></div><p \
class=MsoNormal><br><br><o:p></o:p></p><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><div><p \
class=MsoNormal>_______________________________________________<br>postgis-devel \
mailing list<br><a href="mailto:postgis-devel@lists.osgeo.org" \
target="_blank">postgis-devel@lists.osgeo.org</a><br><a \
href="https://lists.osgeo.org/mailman/listinfo/postgis-devel" \
target="_blank">https://lists.osgeo.org/mailman/listinfo/postgis-devel</a><o:p></o:p></p></div></blockquote></div><p \
class=MsoNormal><o:p>&nbsp;</o:p></p></div><p \
class=MsoNormal>_______________________________________________<br>postgis-devel \
mailing list<br><a href="mailto:postgis-devel@lists.osgeo.org" \
target="_blank">postgis-devel@lists.osgeo.org</a><br><a \
href="https://lists.osgeo.org/mailman/listinfo/postgis-devel" \
target="_blank">https://lists.osgeo.org/mailman/listinfo/postgis-devel</a><o:p></o:p></p></blockquote></div></blockquote></div></div></body></html>



[Attachment #6 (text/plain)]

_______________________________________________
postgis-devel mailing list
postgis-devel@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/postgis-devel

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic