[prev in list] [next in list] [prev in thread] [next in thread] 

List:       postgis-devel
Subject:    Re: [postgis-devel] postgis trunk fails to build with 2.2.1 installed
From:       Greg Troxel <gdt () ir ! bbn ! com>
Date:       2016-01-11 12:12:32
Message-ID: rmiwprg71sf.fsf () fnord ! ir ! bbn ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Sandro Santilli <strk@keybit.net> writes:

> I *think* making sure -I../liblwgeom appearing before any of the system
> directories should also fix the problem, and would be less invasive,
> could you confirm that with your compiler ?

Yes, will try to do a build like that.
But I'm 99.99% sure that's ok too.

Changing to ../ is a bigger change, but on the other hand it makes it
clear that we are including an internal header.  If lwgeom were a
separate package, then we would simply require it be up to date first
and the <> form would give the rigth sense.  But this is just me
expressing a mild style preference - the thing that matters is not
reading the installed file.

Also, arranging may be tricky, though, because it's reasonable for
someone to pass a bunch of -I stuff in CPPFLAGS, including to dirs that
have the old liblwgeom.h.  But if the internal -I are always before the
configure-found -I and the user-provided-CPPFLAGS -I, that should be
ok.


["signature.asc" (application/pgp-signature)]
[Attachment #6 (text/plain)]

_______________________________________________
postgis-devel mailing list
postgis-devel@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/postgis-devel

[prev in list] [next in list] [prev in thread] [next in thread]