[prev in list] [next in list] [prev in thread] [next in thread]
List: postgis-devel
Subject: Re: [postgis-devel] test failure on WKT parser rebuild
From: Paul Ramsey <pramsey () cleverelephant ! ca>
Date: 2014-09-05 15:51:11
Message-ID: etPan.5409dbef.238e1f29.991e () Butterfly ! local
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
The flex and bison on my machine work w/o warnings on what is in trunk right now, and \
the build is clean and regresses, so from my side I'd say everything still looks OK. \
P
--
Paul Ramsey
http://cleverelephant.ca
http://postgis.net
On September 5, 2014 at 8:49:59 AM, Paul Ramsey (pramsey@cleverelephant.ca) wrote:
Did you check in the new parser then?
--
Paul Ramsey
http://cleverelephant.ca
http://postgis.net
On September 5, 2014 at 8:26:09 AM, Sandro Santilli (strk@keybit.net) wrote:
On Fri, Sep 05, 2014 at 04:42:58PM +0200, Sandro Santilli wrote:
> The parser files now generate with no warnings with GNU bison 3.0.2 and
> flex 2.5.35, the build of liblwgeom is also warning-clean and the testsuite
> passes.
>
> But I did not commit re-generated parser files in case anything else
> needs to be tweaked to be compatible with older versions, so I'd ask:
> could you please try the changes locally ? It'd be a matter of running:
>
> make -C liblwgeom/ parser all 2> ERR && make check
>
> The return code of the pipeline shall be zero and ERR shall be empty
I checked with bison 2.5 and things went ok, so pushed a regeneration
of the parser, and also cleaned up the rules to regenerate it when needed.
r12949 and r12950
--strk;
[Attachment #5 (text/html)]
<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body \
style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: \
after-white-space;"><div id="bloop_customfont" \
style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: \
0px; line-height: auto;">The flex and bison on my machine work w/o warnings on what \
is in trunk right now, and the build is clean and regresses, so from my side I'd say \
everything still looks OK. </div><div id="bloop_customfont" \
style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: \
0px; line-height: auto;"><br></div><div id="bloop_customfont" \
style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: \
0px; line-height: auto;">P</div> <div id="bloop_sign_1409932242106917888" \
class="bloop_sign"><div><br></div><span \
style="font-family:helvetica,arial;font-size:13px"></span>-- <br>Paul \
Ramsey<br>http://cleverelephant.ca<div>http://postgis.net</div></div> <br><p \
style="color:#000;">On September 5, 2014 at 8:49:59 AM, Paul Ramsey (<a \
href="mailto:pramsey@cleverelephant.ca">pramsey@cleverelephant.ca</a>) wrote:</p> \
<blockquote type="cite" class="clean_bq"><span><div style="word-wrap: break-word; \
-webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div></div><div>
<title></title>
<div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: \
rgba(0,0,0,1.0); margin: 0px; line-height: auto;"> Did you check in the new parser \
then?</div> <div id="bloop_sign_1409932177813260032" class="bloop_sign">
<div><br></div>
-- <br>
Paul Ramsey<br>
http://cleverelephant.ca
<div>http://postgis.net</div>
</div>
<br>
<p style="color:#000;">On September 5, 2014 at 8:26:09 AM, Sandro
Santilli (<a href="mailto:strk@keybit.net">strk@keybit.net</a>)
wrote:</p>
<blockquote type="cite" class="clean_bq">
<div>
<div><span>On Fri, Sep 05, 2014 at 04:42:58PM +0200, Sandro
Santilli wrote:<br>
<br>
> The parser files now generate with no warnings with GNU bison
3.0.2 and<br>
> flex 2.5.35, the build of liblwgeom is also warning-clean and
the testsuite<br>
> passes.<br>
><br>
> But I did not commit re-generated parser files in case
anything else<br>
> needs to be tweaked to be compatible with older versions, so
I'd ask:<br>
> could you please try the changes locally ? It'd be a matter of
running:<br>
><br>
> make -C liblwgeom/ parser all 2> ERR && make
check<br>
><br>
> The return code of the pipeline shall be zero and ERR shall be
empty<br>
<br>
I checked with bison 2.5 and things went ok, so pushed a
regeneration<br>
of the parser, and also cleaned up the rules to regenerate it when
needed.<br>
<br>
r12949 and r12950<br>
<br>
--strk;<br></span></div>
</div>
</blockquote>
</div></div></span></blockquote></body></html>
_______________________________________________
postgis-devel mailing list
postgis-devel@lists.osgeo.org
http://lists.osgeo.org/cgi-bin/mailman/listinfo/postgis-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic