[prev in list] [next in list] [prev in thread] [next in thread] 

List:       poi-dev
Subject:    [Bug 63774] Custom properties "add" method is slow
From:       bugzilla () apache ! org
Date:       2019-09-26 19:51:25
Message-ID: bug-63774-47293-D8jigqhKSq () https ! bz ! apache ! org/bugzilla/
[Download RAW message or body]

https://bz.apache.org/bugzilla/show_bug.cgi?id=63774

--- Comment #2 from serhiy <serhiy.boychenko@cern.ch> ---
Hello, sorry for replying to a resolved issue, but I still have some concerns
about the proposed solution. I am not really familiar with XSLSX format and
therefore I do not know if "pid" must be unique or not. In case it must be
unique, it is maybe better to use AtomicInteger or something similar, as in
concurrent code execution there is a chance of two different properties ending
up with same pid, otherwise ignore this comment. The second concern I have is
"if(contains(name))" in "add" method, according to my experimentation, this
method is also slow and leads to a bad performance after reaching around 2000
entries in Custom Properties. Therefore I am wondering if the names should be
also cached into a temporary set to improve performance. Sorry once again for
bumping the issue. Best regards, Serhiy.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[prev in list] [next in list] [prev in thread] [next in thread]