[prev in list] [next in list] [prev in thread] [next in thread] 

List:       poi-dev
Subject:    Re: Procedural question
From:       "Javen O'Neal" <javenoneal () gmail ! com>
Date:       2015-11-30 21:32:28
Message-ID: CAM+TppLyi8wMi9FeCvF6ktC5MchHPL7FSV=aMkVoP7+Xa+yhZw () mail ! gmail ! com
[Download RAW message or body]


It sounds like you have one bug dependent on another. I would mark the
first bug as a blocker for the second. In the second bug's patch file,
exclude the changes for the first bug.

Alternatively, you could duplicate the first bug's changes in the patch for
the second bug, and when we integrate them with "svn patch", svn will
discard the duplicate changes.

It doesn't really matter, but fewer total lines of code to review in the
patches might mean faster turn-around time.

Make sure both patches include unit tests if the features aren't already
tested!
On Nov 30, 2015 1:05 PM, "Murphy, Mark" <murphymdev@metalexmfg.com> wrote:

> I have a patch out there (58633) that I created so that I could make a
> border drawing utility that would not be a performance hog. Now I am
> closing in on the border utility being complete, but 58633 is not yet
> checked in. I expect that I should make the new patch dependent on 58633,
> but when I create a diff, it will include the changes I made for 58633.
> Should I exclude those changes somehow, or not when creating a new patch in
> Bugzilla? Or should I include the new functionality in my existing bug
> (58633), I am thinking I should keep them separate, but not sure how to
> proceed.
>


[prev in list] [next in list] [prev in thread] [next in thread]