[prev in list] [next in list] [prev in thread] [next in thread] 

List:       poi-dev
Subject:    cvs commit: jakarta-poi/src/testcases/org/apache/poi/hssf/usermodel TestHSSFCell.java
From:       avik () apache ! org
Date:       2003-10-30 18:14:55
[Download RAW message or body]

avik        2003/10/30 10:14:55

  Modified:    src/java/org/apache/poi/hssf/record BoolErrRecord.java
               src/testcases/org/apache/poi/hssf/usermodel
                        TestHSSFCell.java
  Log:
  fix for bug 16560. But the testcase in HEAD was already failing, so continues to \
fail even now.  
  Revision  Changes    Path
  1.7       +8 -3      \
jakarta-poi/src/java/org/apache/poi/hssf/record/BoolErrRecord.java  
  Index: BoolErrRecord.java
  ===================================================================
  RCS file: /home/cvs/jakarta-poi/src/java/org/apache/poi/hssf/record/BoolErrRecord.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- BoolErrRecord.java	30 Apr 2003 04:38:48 -0000	1.6
  +++ BoolErrRecord.java	30 Oct 2003 18:14:55 -0000	1.7
  @@ -172,14 +172,19 @@
        * set the error value for the cell
        *
        * @param value     error representing the error value
  +     *                  this value can only be 0,7,15,23,29,36 or 42
  +     *                  see bugzilla bug 16560 for an explanation
        */
   
       public void setValue(byte value)
       {
  -        field_4_bBoolErr = value;
  -        field_5_fError   = ( byte ) 1;
  +        if ( (value==0)||(value==7)||(value==15)||(value==23)||(value==29)||(value==36)||(value==42)) \
{  +            field_4_bBoolErr = value;
  +            field_5_fError   = ( byte ) 1;
  +        } else {
  +            throw new RuntimeException("Error Value can only be 0,7,15,23,29,36 or \
42. It cannot be "+value);  +        }
       }
  -
       //public short getRow()
       public int getRow()
       {
  
  
  
  1.9       +2 -2      \
jakarta-poi/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFCell.java  
  Index: TestHSSFCell.java
  ===================================================================
  RCS file: /home/cvs/jakarta-poi/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFCell.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- TestHSSFCell.java	30 Apr 2003 04:38:58 -0000	1.8
  +++ TestHSSFCell.java	30 Oct 2003 18:14:55 -0000	1.9
  @@ -116,7 +116,7 @@
   
               c=r.createCell((short)2);
               //c.setCellType(HSSFCell.CELL_TYPE_ERROR);
  -            c.setCellErrorValue((byte)1);
  +            c.setCellErrorValue((byte)7);
   
   
               wb.write(out);
  @@ -136,7 +136,7 @@
               c = r.getCell((short)1);
               assertTrue("boolean value 0,1 = 0",c.getErrorCellValue() == 0);
               c = r.getCell((short)2);
  -            assertTrue("boolean value 0,2 = 1",c.getErrorCellValue() == 1);
  +            assertTrue("boolean value 0,2 = 7",c.getErrorCellValue() == 7);
   
               in.close();
       }
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: poi-dev-help@jakarta.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]