[prev in list] [next in list] [prev in thread] [next in thread] 

List:       poi-dev
Subject:    Re: YUCK!  Re: cvs commit: jakarta-poi/src/testcases/org/apache/poi/hssf/data
From:       "Andrew C. Oliver" <acoliver () apache ! org>
Date:       2002-05-29 14:48:38
[Download RAW message or body]

Nicola Ken Barozzi wrote:

>From: "Andrew C. Oliver" <acoliver@apache.org>
>
>  
>
>>eeeewwwww....yuck....  there must be a better way.
>>    
>>
>
>Easy, readable, maintainable... what's the problem?
>
>  
>
looks ugly to me.  No matter.  Just my opinion.  I would prefer an if 
statement getting the byte value of the characters
and using ranges.

-Andy

>  
>
>>> -        while (!done)
>>> +        while ( !done )
>>>          {
>>>              int count = stream.read();
>>>  
>>> -            switch (count)
>>> +            switch ( count )
>>>              {
>>>  
>>> -                case '0' :
>>> -                case '1' :
>>> -                case '2' :
>>> -                case '3' :
>>> -                case '4' :
>>> -                case '5' :
>>>      
>>>
>
>etc...
>
>  
>




--
To unsubscribe, e-mail:   <mailto:poi-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:poi-dev-help@jakarta.apache.org>

[prev in list] [next in list] [prev in thread] [next in thread]