[prev in list] [next in list] [prev in thread] [next in thread]
List: pkgsrc-users
Subject: HEADS UP: SunOS users with TOOLS_PLATFORM.sh=bash
From: Jonathan Perkin <jperkin () mnx ! io>
Date: 2022-11-24 9:07:29
Message-ID: Y380UWQyGc8oKpqz () mnx ! io
[Download RAW message or body]
Hi,
With the attached change, anyone building pkgsrc on SunOS platforms that
use bash as their TOOLS_PLATFORM.sh will need to rebuild at least
libtool, and anything else that hardcoded "print" as the way to print
strings.
The failures won't be immediately obvious, it'll only be after looking
at .work.log that you'll see it returning "false". See for example the
top failures for this bulk build:
https://us-central.manta.mnx.io/pkgsrc/public/reports/upstream-trunk/20221123.2250/meta/report.html
Once that's done, however, you'll have a nice performance increase from
not having to execute a separate command every time libtool wants to
print something, which it does quite a lot!
Cheers,
--
Jonathan Perkin - mnx.io - pkgsrc.smartos.org
Open Source Complete Cloud www.tritondatacenter.com
Received: from SJ1PR12MB6075.namprd12.prod.outlook.com (2603:10b6:a03:45e::8)
by DS0PR12MB6415.namprd12.prod.outlook.com with HTTPS; Tue, 22 Nov 2022
09:16:06 +0000
Received: from BN9PR03CA0318.namprd03.prod.outlook.com (2603:10b6:408:112::23)
by SJ1PR12MB6075.namprd12.prod.outlook.com (2603:10b6:a03:45e::8) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Tue, 22 Nov
2022 09:16:03 +0000
Received: from BN7NAM10FT044.eop-nam10.prod.protection.outlook.com
(2603:10b6:408:112:cafe::78) by BN9PR03CA0318.outlook.office365.com
(2603:10b6:408:112::23) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15 via Frontend
Transport; Tue, 22 Nov 2022 09:16:03 +0000
Authentication-Results: spf=neutral (sender IP is 67.231.154.184)
smtp.mailfrom=NetBSD.org; dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=netbsd.org;compauth=softpass
reason=201
Received-SPF: Neutral (protection.outlook.com: 67.231.154.184 is neither
permitted nor denied by domain of NetBSD.org)
Received: from dispatch1-us1.ppe-hosted.com (67.231.154.184) by
BN7NAM10FT044.mail.protection.outlook.com (10.13.157.40) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.5834.8 via Frontend Transport; Tue, 22 Nov 2022 09:16:02 +0000
Authentication-Results-Original: ppe-hosted.com; spf=pass
smtp.mailfrom=netbsd.org; dmarc=none header.from=netbsd.org
header.policy=none;
X-Virus-Scanned: Proofpoint Essentials engine
Received: from mx1-us1.ppe-hosted.com (unknown [10.110.51.172])
by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 0369AE010B
for <jperkin@mnx.io>; Tue, 22 Nov 2022 09:16:00 +0000 (UTC)
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
(No client certificate requested)
by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id C8AC614006A
for <jperkin@mnx.io>; Tue, 22 Nov 2022 09:15:59 +0000 (UTC)
Received: by mail.netbsd.org (Postfix, from userid 605)
id B8C2084E66; Tue, 22 Nov 2022 09:15:52 +0000 (UTC)
Delivered-To: pkgsrc-changes@NetBSD.org
Received: from localhost (localhost [127.0.0.1])
by mail.netbsd.org (Postfix) with ESMTP id EA52584E60
for <pkgsrc-changes@NetBSD.org>; Tue, 22 Nov 2022 09:15:51 +0000 (UTC)
X-Virus-Scanned: amavisd-new at netbsd.org
Received: from mail.netbsd.org ([IPv6:::1])
by localhost (mail.netbsd.org [IPv6:::1]) (amavisd-new, port 10025)
with ESMTP id up6oE8tHfJku for <pkgsrc-changes@netbsd.org>;
Tue, 22 Nov 2022 09:15:51 +0000 (UTC)
Received: from cvs.NetBSD.org (ivanova.NetBSD.org \
[IPv6:2001:470:a085:999:28c:faff:fe03:5984]) by mail.netbsd.org (Postfix) with ESMTP \
id 6C0A184DBD for <pkgsrc-changes@NetBSD.org>; Tue, 22 Nov 2022 09:15:51 +0000 (UTC)
Received: by cvs.NetBSD.org (Postfix, from userid 500)
id 6561DFA90; Tue, 22 Nov 2022 09:15:51 +0000 (UTC)
Content-Transfer-Encoding: 7bit
Content-Type: multipart/mixed; boundary="_----------=_1669108551289970"
Date: Tue, 22 Nov 2022 09:15:51 +0000
From: "Jonathan Perkin" <jperkin@netbsd.org>
Subject: CVS commit: pkgsrc/mk/tools
To: pkgsrc-changes@NetBSD.org
Reply-To: jperkin@netbsd.org
X-Mailer: log_accum
Message-Id: <20221122091551.6561DFA90@cvs.NetBSD.org>
Sender: pkgsrc-changes-owner@NetBSD.org
List-Id: <pkgsrc-changes.NetBSD.org>
Precedence: bulk
List-Unsubscribe: <mailto:majordomo@NetBSD.org?subject=Unsubscribe%20pkgsrc-changes&body=unsubscribe%20pkgsrc-changes>
X-MDID: 1669108560-dHj9wUtveCGZ
Return-Path: bounces-pkgsrc-changes-owner-jperkin=mnx.io@NetBSD.org
X-MS-Exchange-Organization-ExpirationStartTime: 22 Nov 2022 09:16:02.5628
(UTC)
X-MS-Exchange-Organization-ExpirationStartTimeReason: OriginalSubmit
X-MS-Exchange-Organization-ExpirationInterval: 1:00:00:00.0000000
X-MS-Exchange-Organization-ExpirationIntervalReason: OriginalSubmit
X-MS-Exchange-Organization-Network-Message-Id:
8a0d9428-4999-4561-1679-08dacc6a2d57
X-EOPAttributedMessage: 0
X-EOPTenantAttributedMessage: 7cbbbccb-a73b-4293-8866-194afab248db:0
X-MS-Exchange-Organization-MessageDirectionality: Incoming
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN7NAM10FT044:EE_|SJ1PR12MB6075:EE_
X-MS-Exchange-Organization-AuthSource:
BN7NAM10FT044.eop-nam10.prod.protection.outlook.com
X-MS-Exchange-Organization-AuthAs: Anonymous
X-MS-Office365-Filtering-Correlation-Id: 8a0d9428-4999-4561-1679-08dacc6a2d57
X-MS-Exchange-AtpMessageProperties: SA|SL
X-MS-Exchange-Organization-SCL: -1
X-Microsoft-Antispam: BCL:0;
X-Forefront-Antispam-Report:
CIP:67.231.154.184;CTRY:US;LANG:en;SCL:-1;SRV:;IPV:NLI;SFV:NSPM;H:dispatch1-us1.ppe-hosted.com;PTR:dispatch1-us1.ppe-hosted.com;CAT:NONE;SFS:;DIR:INB;
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 09:16:02.4847
(UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a0d9428-4999-4561-1679-08dacc6a2d57
X-MS-Exchange-CrossTenant-Id: 7cbbbccb-a73b-4293-8866-194afab248db
X-MS-Exchange-CrossTenant-AuthSource:
BN7NAM10FT044.eop-nam10.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: Internet
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6075
X-MS-Exchange-Transport-EndToEndLatency: 00:00:03.9609953
X-MS-Exchange-Processed-By-BccFoldering: 15.20.5834.015
X-Microsoft-Antispam-Mailbox-Delivery:
ucf:1;jmr:0;auth:0;dest:C;OFR:CustomRules;ENG:(910001)(944506478)(944626604)(920097)(930097);
X-Microsoft-Antispam-Message-Info:
=?us-ascii?Q?Nm0MU1u6lOXmQSoQJtKN1sfBGlQUFx1ptf1Q1rEhGRML98c8pmhCVuQSgglp?=
=?us-ascii?Q?JFN5cwm+FPKDB6LG31TDHkPekjnTRdsKUBtyiJip+NdaYTYg1SXs2Sfo8bf6?=
=?us-ascii?Q?37dbWwS6xSPKYLJz49GoxSzPBUSc6eTp2RMV4L+nuv84dyqVxH3r1KYtA5kF?=
=?us-ascii?Q?zj64mmm2vhtM/pdH81IWJNngfXLLNpgGVdV/QciYbQ2emR5ryS8ElgClPgqO?=
=?us-ascii?Q?KuFM3qle+ZMV0RNtHPRIOLRcTxcSTZVVX+aLJU2pSn1YLtQTzBG3g2aXnG+c?=
=?us-ascii?Q?DmFa2MQ+NXC/E9zh76Xt1r7bHRspvCgWLnahbmOp21G5eMozqENSGczyoWno?=
=?us-ascii?Q?OHzcqVxqyL3X5JY3DwQa1IxK/CJ0x4uR5jb5qVle085rIs9KTrsfG6LwNqIv?=
=?us-ascii?Q?0nC7suubN4gtOAYHQ2+ID4noZi/F5uFNaiNg8fa8m++3mVVTfXvBAloEf11h?=
=?us-ascii?Q?4w6aEcbmjIgKCXAD+/3kmL80OCMMu42njOBm/8yKpZkVur9q4m0aEG4Qg/0g?=
=?us-ascii?Q?9td1uWSeEUy68g/r1/LovKBxYIlUU+BBTPmgZ5bl8oMnM+J/4NxzEs3S7BMI?=
=?us-ascii?Q?CMCjz/RFiXBZTL+vmk7MTRAJA7VDbUlQauvJLn4wCbi94uvVFPbrqB1UR+1z?=
=?us-ascii?Q?6RFomqBFaun2L4I/+swFyVQc9ZyKBfTRc9BFmk0ex4UEWH/dVm5dKqYCTUP1?=
=?us-ascii?Q?feBpZfQVzVlEuucRNtlwaFsHFjoQBeeYo79gYKWNChHGCZGuH+k4oTwR8U4n?=
=?us-ascii?Q?vaHZrvyu/GECkONpKR0nI4pW3gXvVT1y0eCUr+u6YuW/MZ4dlDtyufFfx50R?=
=?us-ascii?Q?6uMcVeHo/eFSiIgaw87YUDVyR7mblbEhq8VHyyq4sCnerbSGkCWHyyMdA0Jj?=
=?us-ascii?Q?4nGeqP1UaQYC8J2UJYFqnI9quqlwKEXy3M8v7ztPowQtCOmQgNAu9cxn6Kce?=
=?us-ascii?Q?L5GQemkzz4GH9+iSBmNOk7lfPwnTx0I/pjWBK9tNeqOxQYc3IMPFfuAqbkK4?=
=?us-ascii?Q?RDgR3pxHJYE/xtv8v0wbmfpdWrh5TW6BDfmMMxOvECRWpI7VxzTBiu54qruz?=
=?us-ascii?Q?WhJB5krkvhc5r6pDYSsnkn+6LevKtX/eKUxsH6IH+EV6QOFyjJiEAYYjZ9zN?=
=?us-ascii?Q?WfZ1Xi8wBJflAt3SHb/a65paEGMEHmmloKZdSxDM83hsiVOwU5ZW7FbTxsDe?=
=?us-ascii?Q?dmkeSiOa2ZTzWK059kom4od7CzWNXmT923LHmtwvHvAYKdpkpw9GOVXQ4Dc9?=
=?us-ascii?Q?sC4HvVB1qNqbQzQSHRcNgbyboyLh3WmKu4MNESEUH+Kdkj8iJFE+uyf8xwIw?=
=?us-ascii?Q?aOCf/EWNLQfG91iGKrcyq7tNkDsYlEiQdFh4wdty/cAzkSgGfHXKCBsqleib?=
=?us-ascii?Q?FFLykeQS8y53xvbQbrAz8WLVxgVNuATF5OgV14r59q+x6muZxYixKkoohKE3?=
=?us-ascii?Q?5plIUyAk9hKnBaz3kiSfdVlXrn/kg/4rIcKHkq1mpPWwV9jh+b8IPd1HqxIn?=
=?us-ascii?Q?dFJUNLloR1/IQwzquC0qABQ/fx+2hHD5sZ1n9AFr+B27FQPvG3LKiDHvC59R?=
=?us-ascii?Q?mkuziuUvY9ZwH9d5sAMgHSsG3N9OMlomak3JyNPLjlhAgCAhNfJHSiNdj7Ny?=
=?us-ascii?Q?ZqyTlZ92CR/YB8LukhYkeI+M6UbfhYadjwzNbPci3Td4w7GBTDe+CcDHdB8c?=
=?us-ascii?Q?CHj+3dmp3t9I5WMp6OUr0pITKzypjN6i1fCt3U7imJYB4LNDZsBmiFOMdbWl?=
=?us-ascii?Q?WQwVFJnLRENxYdH1HWodboSnOTdrwuofXyAXGFTJNeCEyjAcGshzfmJO/IBl?=
=?us-ascii?Q?eBGo0AXESiGnRBoIfAtSNB+/39RI1p41Ba1sf6sGXNoJadqlAvxy/6fWL75w?=
=?us-ascii?Q?mP/DEXqkScUIo0bVsHRzQBa1AUsycSxS7/j9SLWhzq81qoZ1Tx0/3I2UyaSj?=
=?us-ascii?Q?+tE8lQXDO/vy7uXVxG0yIOeayAGzyQAHY/+fbgBHSN+xe+7aa3Iz3Lk4qyKa?=
=?us-ascii?Q?OxJX?=
MIME-Version: 1.0
--_----------=_1669108551289970
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"
Module Name: pkgsrc
Committed By: jperkin
Date: Tue Nov 22 09:15:51 UTC 2022
Modified Files:
pkgsrc/mk/tools: tools.SunOS.mk
Log Message:
mk/tools: Avoid print(1) when using bash on SunOS.
bash does not have a print builtin, and on SunOS there is a /usr/bin/print
which is found by the libtool configure script (which has also made its way
into lots of third-party packages) and used for printing strings.
Create a broken print wrapper so that this is not found and the printf builtin
is used instead, significantly improving performance.
To generate a diff of this commit:
cvs rdiff -u -r1.54 -r1.55 pkgsrc/mk/tools/tools.SunOS.mk
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
--_----------=_1669108551289970
Content-Disposition: inline
Content-Length: 1166
Content-Transfer-Encoding: binary
Content-Type: text/x-diff; charset=us-ascii
Modified files:
Index: pkgsrc/mk/tools/tools.SunOS.mk
diff -u pkgsrc/mk/tools/tools.SunOS.mk:1.54 pkgsrc/mk/tools/tools.SunOS.mk:1.55
--- pkgsrc/mk/tools/tools.SunOS.mk:1.54 Tue Nov 22 09:09:19 2022
+++ pkgsrc/mk/tools/tools.SunOS.mk Tue Nov 22 09:15:51 2022
@@ -1,4 +1,4 @@
-# $NetBSD: tools.SunOS.mk,v 1.54 2022/11/22 09:09:19 jperkin Exp $
+# $NetBSD: tools.SunOS.mk,v 1.55 2022/11/22 09:15:51 jperkin Exp $
#
# System-supplied tools for the Solaris and illumos operating systems.
#
@@ -229,3 +229,18 @@ TOOLS_PLATFORM.zipcloak?= /usr/bin/zipcl
TOOLS_PLATFORM.zipnote?= /usr/bin/zipnote
TOOLS_PLATFORM.zipsplit?= /usr/bin/zipsplit
.endif
+
+#
+# If we've bootstrapped with bash as the default shell then ensure print is a
+# broken wrapper to work around a bug in the libtool configure script that
+# assumes print, if available, is always a builtin. bash does not have print
+# builtin and /usr/bin/print gets called instead, affecting performance.
+#
+# Also ensure we do use any bash builtins instead of separate commands.
+#
+.if ${TOOLS_PLATFORM.sh:M*bash}
+TOOLS_CREATE+= print
+TOOLS_PATH.print= ${FALSE}
+
+TOOLS_PLATFORM.printf= printf
+.endif
--_----------=_1669108551289970--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic