[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pidgin-devel
Subject:    Re: PidginCellRendererExpander
From:       Jorge_Villaseñor <salinasv () gmail ! com>
Date:       2015-12-23 6:03:52
Message-ID: CAPirPsuN4OH0Wy5fdyZVcY+pm5UP54aFq_OXFNvyOLpORD_uqw () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Mon, Dec 21, 2015 at 11:03 AM, Ethan Blanton <elb@pidgin.im> wrote:

> Jorge Villaseñor spake unto us the following wisdom:
> > I just noticed that we have a PidginCellRendererExpander object which is
> a
> > child of GtkCellRenderer.
> >
> > A quick grep/find shows no code using it. I presume it is dead code.
>
> What about, e.g., gtkblist.c:5614?
>
> > Does anybody knows why do we have this? What is the purpose? Is someone
> > using it?
>
> It is the little triangle disclosure things in the blist.
>
> Ethan
>

Yeah, it is true, it is used by gtkblist.

I just read a little bit more on how we use it and I think we only need
this class to be able
to hide/show the triangle for the Contact. Is this correct?

Isn't there any other way to achieve this? I found GtkExpander, but it
doesn't allow to
hide/show the triangle.

Should we send this code as a patch to Gtk+ so it get's upstreamed?

-- 
Masca

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?

[Attachment #5 (text/html)]

<div dir="ltr">On Mon, Dec 21, 2015 at 11:03 AM, Ethan Blanton <span dir="ltr">&lt;<a \
href="mailto:elb@pidgin.im" target="_blank">elb@pidgin.im</a>&gt;</span> \
wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">Jorge Villaseñor spake unto us the following \
wisdom:<br> <span class="">&gt; I just noticed that we have a \
PidginCellRendererExpander object which is a<br> &gt; child of GtkCellRenderer.<br>
&gt;<br>
&gt; A quick grep/find shows no code using it. I presume it is dead code.<br>
<br>
</span>What about, e.g., gtkblist.c:5614?<br>
<span class=""><br>
&gt; Does anybody knows why do we have this? What is the purpose? Is someone<br>
&gt; using it?<br>
<br>
</span>It is the little triangle disclosure things in the blist.<br>
<span class=""><font color="#888888"><br>
Ethan<br>
</font></span></blockquote></div><br></div><div class="gmail_extra">Yeah, it is true, \
it is used by gtkblist.<br><br>I just read a little bit more on how we use it and I \
think we only need this class to be able<br>to hide/show the triangle for the \
Contact. Is this correct?<br></div><div class="gmail_extra"><br></div><div \
class="gmail_extra">Isn&#39;t there any other way to achieve this? I found \
GtkExpander, but it doesn&#39;t allow to <br></div><div class="gmail_extra">hide/show \
the triangle.<br></div><div class="gmail_extra"><br></div><div \
class="gmail_extra">Should we send this code as a patch to Gtk+ so it get&#39;s \
upstreamed?<br></div><div class="gmail_extra"><br>-- <br><div \
class="gmail_signature">Masca<br><br>A: Because it messes up the order in which \
people normally read text.<br>Q: Why is top-posting such a bad thing?<br>A: \
Top-posting.<br>Q: What is the most annoying thing on usenet and in e-mail?</div> \
</div></div>


[Attachment #6 (text/plain)]

_______________________________________________
Devel mailing list
Devel@pidgin.im
https://pidgin.im/cgi-bin/mailman/listinfo/devel

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic