[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pidgin-commits
Subject:    /pidgin/main: b11347d83ec0: buddy: Fix buddy aliases due to inve...
From:       Mike Ruprecht <cmaiku () gmail ! com>
Date:       2016-09-15 21:14:19
Message-ID: hg.b11347d83ec0.1473974059.-874508059 () rock ! pidgin ! im
[Download RAW message or body]

Changeset: b11347d83ec0ca734f3f68d12c41586d42e03e1d
Author:	 Mike Ruprecht <cmaiku@gmail.com>
Date:	 2016-09-15 14:34 -0500
Branch:	 default
URL: https://hg.pidgin.im/pidgin/main/rev/b11347d83ec0

Description:

buddy: Fix buddy aliases due to inverted purple_strequal()

The usage of purple_strequal() when checking if buddy aliases are
identical to the previous one was accidentally treating it like
g_strcmp0(). purple_strequal() returns TRUE if they are equal
(the opposite). This patch inverts the usage in libpurple/buddy.c
to what was intended.

diffstat:

 libpurple/buddy.c |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diffs (21 lines):

diff --git a/libpurple/buddy.c b/libpurple/buddy.c
--- a/libpurple/buddy.c
+++ b/libpurple/buddy.c
@@ -238,7 +238,7 @@ purple_buddy_set_local_alias(PurpleBuddy
 	if ((alias != NULL) && (*alias != '\0'))
 		new_alias = purple_utf8_strip_unprintables(alias);
 
-	if (!purple_strequal(priv->local_alias, new_alias)) {
+	if (purple_strequal(priv->local_alias, new_alias)) {
 		g_free(new_alias);
 		return;
 	}
@@ -294,7 +294,7 @@ purple_buddy_set_server_alias(PurpleBudd
 	if ((alias != NULL) && (*alias != '\0') && g_utf8_validate(alias, -1, NULL))
 		new_alias = purple_utf8_strip_unprintables(alias);
 
-	if (!purple_strequal(priv->server_alias, new_alias)) {
+	if (purple_strequal(priv->server_alias, new_alias)) {
 		g_free(new_alias);
 		return;
 	}

_______________________________________________
Commits mailing list
Commits@pidgin.im
https://pidgin.im/cgi-bin/mailman/listinfo/commits
[prev in list] [next in list] [prev in thread] [next in thread]