[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pidgin-commits
Subject:    /pidgin/main: a658571d344d: irc: Store strlen() value to avoid c...
From:       Mike Ruprecht <cmaiku () gmail ! com>
Date:       2016-05-15 15:11:27
Message-ID: hg.a658571d344d.1463325087.-874508059 () rock ! pidgin ! im
[Download RAW message or body]

Changeset: a658571d344d7933ec09a5c525a3a3299dde347f
Author:	 Mike Ruprecht <cmaiku@gmail.com>
Date:	 2016-05-01 19:34 -0500
Branch:	 default
URL: https://hg.pidgin.im/pidgin/main/rev/a658571d344d

Description:

irc: Store strlen() value to avoid calling it twice in irc_send_len()

diffstat:

 libpurple/protocols/irc/irc.c |  6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diffs (30 lines):

diff --git a/libpurple/protocols/irc/irc.c b/libpurple/protocols/irc/irc.c
--- a/libpurple/protocols/irc/irc.c
+++ b/libpurple/protocols/irc/irc.c
@@ -121,6 +121,7 @@ int irc_send(struct irc_conn *irc, const
 int irc_send_len(struct irc_conn *irc, const char *buf, int buflen)
 {
  	char *tosend= g_strdup(buf);
+	int len;
 	GBytes *data;
 
 	purple_signal_emit(_irc_protocol, "irc-sending-text", \
purple_account_get_connection(irc->account), &tosend); @@ -128,7 +129,8 @@ int \
irc_send_len(struct irc_conn *irc, c  if (tosend == NULL)
 		return 0;
 
-	data = g_bytes_new_take(tosend, strlen(tosend));
+	len = strlen(tosend);
+	data = g_bytes_new_take(tosend, len);
 	purple_queued_output_stream_push_bytes(irc->output, data);
 	g_bytes_unref(data);
 
@@ -140,7 +142,7 @@ int irc_send_len(struct irc_conn *irc, c
 				purple_account_get_connection(irc->account));
 	}
 
-	return strlen(tosend);
+	return len;
 }
 
 /* XXX I don't like messing directly with these buddies */

_______________________________________________
Commits mailing list
Commits@pidgin.im
https://pidgin.im/cgi-bin/mailman/listinfo/commits


[prev in list] [next in list] [prev in thread] [next in thread]