[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pidgin-commits
Subject:    /pidgin/main: d6627d91a2d2: Use the GError through the function
From:       Jorge Villase?or <salinasv () pidgin ! im>
Date:       2016-05-11 3:01:05
Message-ID: hg.d6627d91a2d2.1462935665.-874508059 () rock ! pidgin ! im
[Download RAW message or body]

Changeset: d6627d91a2d25c45f1be1227ae8cf7d6d4b2bb99
Author:	 Jorge Villase?or <salinasv@pidgin.im>
Date:	 2016-05-07 15:16 -0700
Branch:	 default
URL: https://hg.pidgin.im/pidgin/main/rev/d6627d91a2d2

Description:

Use the GError through the function

Previously the GError was declared and set to NULL but not assigned
anywere. Later it was used as a branching statement which will always
take the same path, since it was always NULL.

CID-1359226

diffstat:

 pidgin/gtkcertmgr.c |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diffs (21 lines):

diff --git a/pidgin/gtkcertmgr.c b/pidgin/gtkcertmgr.c
--- a/pidgin/gtkcertmgr.c
+++ b/pidgin/gtkcertmgr.c
@@ -317,7 +317,7 @@ tls_peers_mgmt_info_cb(GtkWidget *button
 	GtkTreeModel *model;
 	gchar *id;
 	GTlsCertificate *crt;
-	char *title;
+	gchar *title;
 	GError *error = NULL;
 
 	/* See if things are selected */
@@ -331,7 +331,7 @@ tls_peers_mgmt_info_cb(GtkWidget *button
 	gtk_tree_model_get(model, &iter, TPM_HOSTNAME_COLUMN, &id, -1);
 
 	/* Now retrieve the certificate */
-	crt = purple_tls_certificate_new_from_id(id, NULL);
+	crt = purple_tls_certificate_new_from_id(id, &error);
 
 	if (crt == NULL) {
 		purple_debug_warning("gtkcertmgr/tls_peers_mgmt",

_______________________________________________
Commits mailing list
Commits@pidgin.im
https://pidgin.im/cgi-bin/mailman/listinfo/commits
[prev in list] [next in list] [prev in thread] [next in thread]