[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pidgin-commits
Subject:    /pidgin/main: 276f9ebffb88: Merged in EionRobb/pidgin/EionRobb/h...
From:       Gary Kramlich <grim () reaperworld ! com>
Date:       2016-02-09 19:36:18
Message-ID: hg.276f9ebffb88.1455046578.-874508059 () rock ! pidgin ! im
[Download RAW message or body]

Changeset: 276f9ebffb8809ec0db5b7bd0f32da3a8ae25cba
Author:	 Gary Kramlich <grim@reaperworld.com>
Date:	 2016-02-09 13:35 -0600
Branch:	 default
URL: https://hg.pidgin.im/pidgin/main/rev/276f9ebffb88

Description:

Merged in EionRobb/pidgin/EionRobb/httpc-edited-online-with-bitbucket-1454996408809 (pull request #18)

Fix for infinite loop when a chunked HTTP connection is terminated mid-chunk

diffstat:

 libpurple/http.c |  4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diffs (14 lines):

diff --git a/libpurple/http.c b/libpurple/http.c
--- a/libpurple/http.c
+++ b/libpurple/http.c
@@ -1190,6 +1190,10 @@ static gboolean _purple_http_recv_loopbo
 		const gchar *redirect;
 
 		if (hc->is_chunked && !hc->chunks_done) {
+			if (len == 0) {
+				_purple_http_error(hc, _("Chunked connection terminated"));
+				return FALSE;
+			}
 			if (purple_debug_is_verbose()) {
 				purple_debug_misc("http",
 					"I need the terminating empty chunk\n");

_______________________________________________
Commits mailing list
Commits@pidgin.im
https://pidgin.im/cgi-bin/mailman/listinfo/commits
[prev in list] [next in list] [prev in thread] [next in thread]