[prev in list] [next in list] [prev in thread] [next in thread] 

List:       phpdoc
Subject:    [PHP-DOC] Re: Broken build for translations
From:       Alexey Shein <confik () gmail ! com>
Date:       2011-07-28 13:48:51
Message-ID: CAAAa2si0bneuCYLpiVZjW7iQk5__E8PAquCQPp=XK0Mwi-ELOQ () mail ! gmail ! com
[Download RAW message or body]

2011/7/28 Hannes Magnusson <hannes.magnusson@gmail.com>:
> On Thu, Jul 28, 2011 at 15:30, Hannes Magnusson
> <hannes.magnusson@gmail.com> wrote:
>> On Thu, Jul 28, 2011 at 13:40, Alexey Shein <confik@gmail.com> wrote:
>>> 2011/7/28 Hannes Magnusson <hannes.magnusson@gmail.com>:
>>>> On Thu, Jul 28, 2011 at 13:14, Alexey Shein <confik@gmail.com> wrote:
>>>>> There is a bug in configure.php with improper handling
>>>>> @ENGLISH_ONLY_INCL_BEGIN@ directive, i created the fix (see
>>>>> attachment).
>>>>> If it's ok I will commit it.
>>>>
>>>>
>>>> Whopsy. Forgot to provide a default for it :)
>>>>
>>>> You need those entities for translations, not english :]
>>>>
>>>
>>> That's why I renamed them in the patch.
>>> Ok, I will commit.
>>
>> I already did fix it by initializing the variable with empty string...
>>
>
> See your commit now..
> I don't see how "translation only" makes sense here.. you can't build
> a translation standalone.. it will comment out those entries when you
> only build the english translation..

It's just english_only* name had made even less sense and i didn't
find how to name it better. Just wanted to note that this part is
enabled only in non-english builds, that was unclear with old name.

>
> Anyway. Not worth another commit again imo :)
>
agreed :)

> -Hannes
>



-- 
Regards,
Shein Alexey
[prev in list] [next in list] [prev in thread] [next in thread]