[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-qa
Subject:    Re: [PHP-QA] tests/basic/021.phpt typo
From:       Johannes =?ISO-8859-1?Q?Schl=FCter?= <johannes () schlueters ! de>
Date:       2010-11-18 18:10:32
Message-ID: 1290103832.16819.188.camel () guybrush
[Download RAW message or body]

On Wed, 2010-11-17 at 17:04 +0200, Eyal Teutsch wrote:
> Hi Felipe & Patrick,
> 
> thank you both for your prompt replies.
> 
> How do I actually obtain commit access to tests?

If you don't have an account, yet fill out this form:
http://www.php.net/svn-php.php
(be careful at the "For what purpose do you require a SVN account"
question ;-) ) This will then require manual approval so it could take a
day or two (or more) for being processed.

I case you already have an account: What's the username?

johannes

> thx,
> 
> Eyal
> 
> On 11/17/2010 04:51 PM, Felipe Pena wrote:
> > 2010/11/17 Patrick ALLAERT <patrickallaert@php.net 
> > <mailto:patrickallaert@php.net>>
> >
> >     Forgot to "reply to all" (fixed).
> >
> >     2010/11/17 Patrick ALLAERT <patrickallaert@php.net
> >     <mailto:patrickallaert@php.net>>:
> >     > Hi Eyal,
> >     >
> >     > 2010/11/17 Eyal Teutsch <eyal.t@zend.com <mailto:eyal.t@zend.com>>:
> >     >> Hi,
> >     >>
> >     >> 021.phpt under tests/basic has a typo in it's INI section - it has:
> >     >> file_upload=1
> >     >>
> >     >> while should actually be (with a 's'):
> >     >> file_uploads=1
> >     >>
> >     >> Should I commit to both:
> >     >>
> >     http://svn.php.net/repository/php/php-src/branches/PHP_5_2/tests/basic/021.phpt
> >     >>
> >     http://svn.php.net/repository/php/php-src/branches/PHP_5_3/tests/basic/021.phpt
> >     >
> >     > If you have commit access to these tests, feel free to do so,
> >     this is
> >     > indeed a typo which should be fixed!
> >     > Don't forget to also adapt the file in trunk:
> >     > http://svn.php.net/repository/php/php-src/trunk/tests/basic/021.phpt
> >     >
> >
> >
> > Opss, I supposed you have no access, then committed the fix.
> > If you have, just commit next time! :P
> >
> > -- 
> > Regards,
> > Felipe Pena
> 



-- 
PHP Quality Assurance Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

[prev in list] [next in list] [prev in thread] [next in thread]