[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-internals
Subject:    Re: [PHP-DEV] NAN/INF->int conversion in 5.6
From:       Florian Anderiasch <ml () anderiasch ! de>
Date:       2015-06-28 9:58:46
Message-ID: 558FC556.40405 () anderiasch ! de
[Download RAW message or body]

On 28.06.2015 02:46, Stanislav Malyshev wrote:

> My question is: should we backport code from PHP 7 that checks for
> infinity/nan and put it into 5.6? Or it's not worth it and it's ok for
> 5.6 to return random weird stuff there? (I know it's not exactly random
> and there's a reason why it's that number but it looks that way).

While I can't imagine many people would stumble over this (as apparently
there was no bug report) it could be a tricky one if you're not extra
paranoid when working with INF, I don't think it's worth changing this
behaviour so long after 5.6.0 was released. Good that it's fixed in 7
though.

It should absolutely be documented (and I still can't fathom why
searching for INF on the website only gives me function results and not
a direct hit for a 1:1 match on a pre-defined constant in core, but
let's not start this discussion.)

Greetings,
Florian

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[prev in list] [next in list] [prev in thread] [next in thread]