[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-internals
Subject:    Re: [PHP-DEV] Bug 44383 in ext/soap
From:       Michael Maclean <michael () no-surprises ! co ! uk>
Date:       2010-03-31 18:27:05
Message-ID: 4BB393F9.2030800 () no-surprises ! co ! uk
[Download RAW message or body]

David Zülke wrote:
> On 25.03.2010, at 22:05, Michael Maclean wrote:
> Did you also succeed in compiling it as a standalone extension? Could 
> you try? There were some dependencies on ext/date symbols that gave me a 
> hard time when trying that back then... and I lack(ed) the C-fu to fix 
> that.

Oh, I hadn't tried that, I'll give it a go.

> 
>> The updated version of David's patch is available here: 
>> http://mgdm.net/~michael/patches/bug44383.txt
>>
>> (I noticed a couple of problems with the schema tests, 089 and 091 - 
>> it seemed that the test originally expected the timezone offsets to be 
>> applied in the wrong direction - I could do with a second opinion on 
>> this.)
> Yes, I think I remember something in that direction. Some timezone 
> offsets behaved weird; back then I think I concluded that the tests must 
> have been wrong as a bug related to that in ext/date was unlikely.
> Could you list the tested values with expected and actual results? It's 
> only a few IIRC, and it'd make it easier to discuss.

Sure, there were only two, as I recall. I'll dig them out and mail back.

-- 
Cheers,
Michael

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[prev in list] [next in list] [prev in thread] [next in thread]