[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-internals
Subject:    [PHP-DEV] Re: Patch: Reflection Exception Messages
From:       217.114.211.68
Date:       2010-03-28 15:59:29
Message-ID: slrnhquv6u.o2j.dsp () experimentalworks ! net
[Download RAW message or body]

On 2010-03-28, Benjamin Eberlei <kontakt@beberlei.de> wrote:
> Index: ext/reflection/php_reflection.c
>===================================================================
> --- ext/reflection/php_reflection.c	(revision 296963)
> +++ ext/reflection/php_reflection.c	(working copy)
> @@ -3425,7 +3425,7 @@
>  	} else {
>  		efree(lc_name);
>  		zend_throw_exception_ex(reflection_exception_ptr, 0 TSRMLS_CC, 
> -				"Method %s does not exist", name);
> +				"Method %s::%s() does not exist", ce->name, name);
>  		return;
>  	}
>  }
> @@ -3602,7 +3602,7 @@
>  		}		
>  	}
>  	zend_throw_exception_ex(reflection_exception_ptr, 0 TSRMLS_CC, 
> -			"Property %s does not exist", name);
> +			"Property %s::%s does not exist", ce->name, name);
>  }
>  /* }}} *
>
> The patch is against SVN trunk.

looks good for me. if there are no objections from someone else I'll
commit it tomorrow.

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[prev in list] [next in list] [prev in thread] [next in thread]