[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-internals
Subject:    Re: [PHP-DEV] PATCH for bug #47199
From:       Joey Smith <joey () joeysmith ! com>
Date:       2010-02-09 16:31:20
Message-ID: 20100209163119.GA2538 () joeysmith ! com
[Download RAW message or body]

If anyone ever needs me to host a patch, there's more than enough
room at patch.joeysmith.com, just email me the patch as an attachment
off-list. It'd probably be better than relying on a pastebin.

On Tue, Feb 09, 2010 at 04:38:44PM +0100, Johannes Schlüter wrote:
> Hi,
> 
> On Tue, 2010-02-09 at 20:11 +0500, Sokolov Evgeniy wrote:
> > > did you really run this test and was it successful? - doesn't looklike
> > > for me.
> > I just run "php tests/27_bug47199.phpt" and check the result output.
> > Is this correct way?
> 
> The easy way to run it using the test Framework is by executing
> 
>    make test TESTS=tests/27_bug47199.phpt
> 
> from your build directory which will prepare some environment things and
> then run run-tests.php from PHP's source directory which has the
> implementation of our test system, you can also run it directly to have
> more ocntrol. See README.TESTING in the php-src root folder and
> http://qa.php.net/write-test.php for more details on the test system.
> 
> If you run your test it will tell you it failed as you're tests EXPECTF
> section has to look something like this:
> 
> --EXPECTF--
> DELETE FROM %s WHERE null_field IS NULL AND not_null_field=2;
> Done
> 
> Mind the %s place holder there!
> 
> > > And please also add a link to the patch to the bug report
> > Can it be link on pastebin.org? For example http://pastebin.org/88880
> 
> I don't know how persistent these pastebins are,
> http://news.php.net/php.internals/46965 might be an alternative link
> though :-)
> 
> johannes
> 
> 
> 
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
> 

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[prev in list] [next in list] [prev in thread] [next in thread]