[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-internals
Subject:    Re: [PHP-DEV] Re: [PATCH] double to long conversion change
From:       Stanislav Malyshev <stas () zend ! com>
Date:       2009-04-22 18:43:18
Message-ID: 49EF6546.7010700 () zend ! com
[Download RAW message or body]

Hi!

> Really, I don't understand what it's going to fix (the need of 
> preserving low bits looks strange for me).

 From what I understand the idea of the patch is what we are doing if we 
try to convert double that's too big for long into long (please correct 
me if I'm talking nonsense here). We'd then have to "cut" it, and as I 
understand there could be two approaches - either bitwise cut or just 
putting there some pre-determined value like LONG_MAX. I also understand 
the former was behavior in 5.2 and before (but not in 5.3 as of now), 
and thus I think it makes sense to keep this behavior, unless there is 
some serious problem with it - and I understand we don't know now about 
any such problem. Am I right?

> Also it breaks ~30 tests.

Now that should be checked out - are those directly related to the said 
conversion (i.e. the issue is that the tests just expect different 
behavior which is natural and we just have to fix the tests) or those 
are independent tests.
-- 
Stanislav Malyshev, Zend Software Architect
stas@zend.com   http://www.zend.com/
(408)253-8829   MSN: stas@zend.com

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[prev in list] [next in list] [prev in thread] [next in thread]