[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-gtk-cvs
Subject:    [php-gtk-cvs] com gtk/php-gtk: We do need to ref the wrapper before storing it.: =?UTF-8?Q?main/php=
From:       David Soria Parra <dsp () php ! net>
Date:       2001-02-28 16:14:20
Message-ID: php-mail-d3fd2bbe087235b1453910dd9a9025b6302695011 () git ! php ! net
[Download RAW message or body]

Commit:    97777635afe417bceb0c83519bd61839facef330
Author:    Andrei Zmievski <andrei@php.net>         Wed, 28 Feb 2001 16:14:20 +0000
Parents:   eadf4058d70b38c1b77d6ddcc7062c2aa068ddc4
Branches:  GTK2 PHP_GTK_1 ZE2_PORT devel master

Link:       http://git.php.net/?p=gtk/php-gtk.git;a=commitdiff;h=97777635afe417bceb0c83519bd61839facef330

Log:
We do need to ref the wrapper before storing it.

Changed paths:
  M  main/php_gtk.c
  M  main/php_gtk_object.c


Diff:
97777635afe417bceb0c83519bd61839facef330
diff --git a/main/php_gtk.c b/main/php_gtk.c
index fdbc92d..9d1241a 100644
--- a/main/php_gtk.c
+++ b/main/php_gtk.c
@@ -208,7 +208,7 @@ PHP_MINFO_FUNCTION(gtk)
 	php_info_print_table_start();
 	php_info_print_table_row(2, "GTK+ support", "enabled");
 	sprintf(buf, "%d.%d.%d", gtk_major_version, gtk_minor_version, gtk_micro_version);
-	php_info_print_table_row(2, "GTK+ Version", buf);
+	php_info_print_table_row(2, "GTK+ v", buf);
 	php_info_print_table_end();
 
 	/* Remove comments if you have entries in php.ini
diff --git a/main/php_gtk_object.c b/main/php_gtk_object.c
index 16fe3b4..1bbd85a 100644
--- a/main/php_gtk_object.c
+++ b/main/php_gtk_object.c
@@ -46,8 +46,10 @@ void php_gtk_set_object(zval *wrapper, void *obj, int rsrc_type)
 	Z_TYPE_P(handle) = IS_LONG;
 	Z_LVAL_P(handle) = zend_list_insert(obj, rsrc_type);
 	zend_hash_index_update(Z_OBJPROP_P(wrapper), 0, &handle, sizeof(zval *), NULL);
-	if (rsrc_type == le_gtk)
+	if (rsrc_type == le_gtk) {
+		zval_add_ref(&wrapper);
 		gtk_object_set_data_full(obj, php_gtk_wrapper_key, wrapper, php_gtk_destroy_notify);
+	}
 }
 
 void *php_gtk_get_object(zval *wrapper, int rsrc_type)


--
PHP-GTK CVS Mailing List (http://gtk.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[prev in list] [next in list] [prev in thread] [next in thread]