[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-general
Subject:    [PHP] Redundant isset() check?
From:       Dotan Cohen <dotancohen () gmail ! com>
Date:       2014-11-04 11:25:31
Message-ID: CAKDXFkN6EQUhdrWJnR1p-_d8dZWz348c9Xa4BesMUBnbizHspg () mail ! gmail ! com
[Download RAW message or body]

Consider the situation where an application will use a different set
of PDO connection details depending on which version of the site is
running: production, dev, qa, cron job, etc. Considering that
$_SERVER['DOCUMENT_ROOT'] may not be set, is this check sufficient:

if ( !isset( !isset($connection_details[$_SERVER['DOCUMENT_ROOT']]) ) {

Or would it be preferable to first check that
$_SERVER['DOCUMENT_ROOT'] is set before relying on it:

if ( !isset($_SERVER['DOCUMENT_ROOT']) ||
!isset($connection_details[$_SERVER['DOCUMENT_ROOT']]) ) {

The TRUE case of this if clause will simply use the default connection details:
$connection_details[0]

-- 
Dotan Cohen

http://gibberish.co.il
http://what-is-what.com

-- 
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[prev in list] [next in list] [prev in thread] [next in thread]