[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-doc-cvs
Subject:    [DOC-CVS] [doc-en] master: Correct note to state behavior is still possible
From:       Agustin Gomes via GitHub <noreply () php ! net>
Date:       2021-11-24 17:37:22
Message-ID: 9xqyRKC2r6w8kDnyqvZARkOdVHWxjXipG2Wa0cADkE () main ! php ! net
[Download RAW message or body]

Author: Agustin Gomes (agustingomes)
Committer: GitHub (web-flow)
Pusher: cmb69
Date: 2021-11-24T18:38:06+01:00

Commit: https://github.com/php/doc-en/commit/9dd74f527dc164165dee7f19058bec75a901e770
Raw diff: https://github.com/php/doc-en/commit/9dd74f527dc164165dee7f19058bec75a901e770.diff

Correct note to state behavior is still possible

The behavior in the Example #7 Old way to make arguments nullable
is still possible in PHP today.

For reference, I thought initially this was a bug in the PHP Core,
and tried to add the respective test case in the PR:

https://github.com/php/php-src/pull/7627

Closes GH-1142.

Changed paths:
  M  language/types/declarations.xml


Diff:

diff --git a/language/types/declarations.xml b/language/types/declarations.xml
index 2ab128461b..118608c398 100644
--- a/language/types/declarations.xml
+++ b/language/types/declarations.xml
@@ -348,7 +348,7 @@ function get_item(): ?string {
 
   <note>
    <para>
-    Prior to PHP 7.1.0, it was possible to achieve nullable arguments by making
+    It is possible to achieve nullable arguments by making
     <literal>null</literal> the default value.
     This is not recommended as this breaks during inheritance.
    </para>

-- 
PHP Documentation Commits Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic