[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-doc-cvs
Subject:    Re: [DOC-CVS] svn: /phpdoc/en/trunk/appendices/ reserved.constants.core.xml
From:       Yoshinari Takaoka <mumumu () mumumu ! org>
Date:       2019-12-20 10:22:29
Message-ID: 20191220192229.0e61113b45d386614cf86d4e () mumumu ! org
[Download RAW message or body]

On Fri, 20 Dec 2019 09:47:43 +0000
Peter Cowburn <petercowburn@gmail.com> wrote:

> The original text was correct. Note that we're talking about negative
> floating point numbers there.

Thank you for pointing out. I missed negative floating number context.
To emphasis the negative number context, what do you think the following patch?

----

Index: en/appendices/reserved.constants.core.xml
===================================================================
--- en/appendices/reserved.constants.core.xml   ($B%j%S%8%g%s(B 348608)
+++ en/appendices/reserved.constants.core.xml   ($B:n6H%3%T!<(B)
@@ -237,7 +237,7 @@
      <listitem>
       <simpara>
        Smallest representable <emphasis>positive</emphasis> floating point number.
-       If you need the largest representable floating point number, use <literal>- \
PHP_FLOAT_MAX</literal>. +       If you need the smallest (negative) representable \
floating point number, use <literal>- PHP_FLOAT_MAX</literal>.  Available as of PHP \
7.2.0.                                  </simpara>                                    \
  </listitem> 

-- 
Yoshinari Takaoka
reversethis -> gro tod umumum ta umumum


On Fri, 20 Dec 2019 09:47:43 +0000
Peter Cowburn <petercowburn@gmail.com> wrote:

> On Thu, 19 Dec 2019 at 23:22, Yoshinari Takaoka <mumumu@php.net> wrote:
> 
> > mumumu                                   Thu, 19 Dec 2019 23:22:06 +0000
> > 
> > Revision: http://svn.php.net/viewvc?view=revision&revision=348608
> > 
> > Log:
> > fixed documentation bug about mentioning PHP_FLOAT_MAX. not smallest but
> > largest.
> > 
> > Changed paths:
> > U   phpdoc/en/trunk/appendices/reserved.constants.core.xml
> > 
> > Modified: phpdoc/en/trunk/appendices/reserved.constants.core.xml
> > ===================================================================
> > --- phpdoc/en/trunk/appendices/reserved.constants.core.xml      2019-12-19
> > 23:18:12 UTC (rev 348607)
> > +++ phpdoc/en/trunk/appendices/reserved.constants.core.xml      2019-12-19
> > 23:22:06 UTC (rev 348608)
> > @@ -237,7 +237,7 @@
> > <listitem>
> > <simpara>
> > Smallest representable <emphasis>positive</emphasis> floating
> > point number.
> > -       If you need the smallest representable floating point number, use
> > <literal>- PHP_FLOAT_MAX</literal>.
> > +       If you need the largest representable floating point number, use
> > <literal>- PHP_FLOAT_MAX</literal>.
> > 
> 
> The original text was correct. Note that we're talking about negative
> floating point numbers there.
> 
> 
> > Available as of PHP 7.2.0.
> > </simpara>
> > </listitem>
> > 
> > 
> > --
> > PHP Documentation Commits Mailing List (http://www.php.net/)
> > To unsubscribe, visit: http://www.php.net/unsub.php


-- 
Yoshinari Takaoka
reversethis -> gro tod umumum ta umumum

-- 
PHP Documentation Commits Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php


[prev in list] [next in list] [prev in thread] [next in thread]