[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-doc-cvs
Subject:    [DOC-CVS] Re: com phd: Fixed bug #44498 (RTL manual entries display issues): package.xmlphpdotnet/ph
From:       "Christoph M. Becker" <cmbecker69 () gmx ! de>
Date:       2018-07-23 15:31:11
Message-ID: 39b6d74e-d20f-4c4a-bcf2-15c1efb64734 () gmx ! de
[Download RAW message or body]

Hi Kalle!

On 23.07.2018 at 12:50, Kalle Sommer Nielsen wrote:

> Commit:    0cffbf99a466ee74068aeaad63c9f9fc5fd2761d
> Author:    Kalle Sommer Nielsen <kalle@php.net>         Mon, 23 Jul 2018 12:50:42 +0200
> Parents:   5cc08e5c4aef28a63a10c7bf5ab1f78dbe62b7ee
> Branches:  master
> 
> Link:       http://git.php.net/?p=phd.git;a=commitdiff;h=0cffbf99a466ee74068aeaad63c9f9fc5fd2761d
> 
> Log:
> Fixed bug #44498 (RTL manual entries display issues)
> 
> Bugs:
> https://bugs.php.net/44498
> 
> Changed paths:
>   M  package.xml
>   M  phpdotnet/phd/Package/PHP/XHTML.php
> 
> 
> Diff:
> diff --git a/package.xml b/package.xml
> index 484a2ef..8cf90a3 100644
> --- a/package.xml
> +++ b/package.xml
> @@ -71,12 +71,13 @@
>    </stability>
>    <license uri="http://www.opensource.org/licenses/bsd-license.php">BSD Style</license>
>    <notes>
> -    Added new language translations: (Kalle)
> -     - Norwegian (Bokmål)
> -    Updated language translations: (Kalle)
> -     - Danish
> -     - Swedish
> -    Fixed bug#66408 (Wrong style file in chm documentation). (Andy Burton)
> +    - Added new language translations: (Kalle)
> +      . Norwegian (Bokmål)
> +    - Updated language translations: (Kalle)
> +      . Danish
> +      . Swedish
> +    - Fixed bug #44498 (RTL manual entries display issues). (Kalle)
> +    - Fixed bug #66408 (Wrong style file in chm documentation). (Andy Burton)
>    </notes>
>  
>    <contents>
> diff --git a/phpdotnet/phd/Package/PHP/XHTML.php b/phpdotnet/phd/Package/PHP/XHTML.php
> index 48f60df..bc03724 100644
> --- a/phpdotnet/phd/Package/PHP/XHTML.php
> +++ b/phpdotnet/phd/Package/PHP/XHTML.php
> @@ -1,4 +1,4 @@
> -<?php
> +<?php
>  namespace phpdotnet\phd;
>  
>  abstract class Package_PHP_XHTML extends Package_Generic_XHTML {
> @@ -19,6 +19,7 @@ abstract class Package_PHP_XHTML extends Package_Generic_XHTML {
>          'phpdoc:classref'       => 'format_class_chunk',
>          'phpdoc:exceptionref'   => 'format_class_chunk',
>          'phpdoc:varentry'       => 'format_varentry_chunk',
> +	'programlisting'	=> 'format_programlisting',
>          'refentry'              => 'format_chunk',
>          'reference'             => 'format_container_chunk',
>          'refpurpose'            => 'format_refpurpose',
> @@ -736,6 +737,19 @@ abstract class Package_PHP_XHTML extends Package_Generic_XHTML {
>          return $this->format_container_chunk($open, "reference", $attrs, $props);
>      }
>  
> +    public function format_programlisting($open, $name, $attrs) {
> +        if ($open) {
> +            if (isset($attrs[Reader::XMLNS_DOCBOOK]["role"])) {
> +                $this->role = $attrs[Reader::XMLNS_DOCBOOK]["role"];
> +            } else {
> +                $this->role = false;
> +            }
> +
> +            return '<div class="example-contents" dir="ltr">';
> +        }
> +        $this->role = false;
> +        return "</div>\n";
> +    }
>  }
>  
>  /*

It seems this commit broke the doc build.  Creating .manual.xml works,
but phd fails:

  16:15:14 - Indexing              Indexing done
  =============> Something happenend when snapshotting en
  Failed completely
  =============> Please have a look!

I can't reproduce the failure on machine, though.

-- 
Christoph M. Becker

-- 
PHP Documentation Commits Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[prev in list] [next in list] [prev in thread] [next in thread]