[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-doc-cvs
Subject:    Re: [DOC-CVS] svn: /phpdoc/en/trunk/reference/session/functions/ session-name.xml
From:       "Christoph M. Becker" <cmbecker69 () gmx ! de>
Date:       2018-05-26 11:22:20
Message-ID: 5d3c5c69-6af3-ac68-645d-9b971763dd4f () gmx ! de
[Download RAW message or body]

On 26.05.2018 at 13:03, Peter Cowburn wrote:

> On 26 May 2018 at 02:32, Yasuo Ohgaki <yohgaki@php.net> wrote:
> 
>> yohgaki                                  Sat, 26 May 2018 01:32:52 +0000
>>
>> Revision: http://svn.php.net/viewvc?view=revision&revision=345059
>>
>> Log:
>> Add correct usage descriptions to session_name().
>>
>> Changed paths:
>>     U   phpdoc/en/trunk/reference/session/functions/session-name.xml
>>
>> Modified: phpdoc/en/trunk/reference/session/functions/session-name.xml
>> ===================================================================
>> --- phpdoc/en/trunk/reference/session/functions/session-name.xml
>> 2018-05-25 16:06:37 UTC (rev 345058)
>> +++ phpdoc/en/trunk/reference/session/functions/session-name.xml
>> 2018-05-26 01:32:52 UTC (rev 345059)
>> @@ -19,6 +19,15 @@
>>     the <emphasis>old</emphasis> session name.
>>    </para>
>>    <para>
>> +   <function>session_name</function> modifies HTTP cookie (and output
>> contents
>> +   when <literal>session.transid</literal> is enabled). Once HTTP cookie
>> is sent,
>> +   <function>session_name</function> raises error.
>> +  </para>
>> +  <para>
>> +   <function>session_name</function> must be called before
>> <function>session_start</function>
>> +   in order session to work properly. Otherwise, it raises error.
>> +  </para>
>> +  <para>
>>
> 
> The above change now (mistakenly, I hope) states:
> a) Calling session_name() with no arguments modifies the HTTP cookie
> b) Calling session_name() with no arguments MUST NOT happen AFTER
> session_start()
> 
> Neither of those points are correct, right?  It is not clear that the new
> paragraphs are applicable only when using the $name parameter.

Furthermore, it might be best to resolve <https://bugs.php.net/76358>
first, i.e. to get consensus on whether it is a bug or a documentation
problem.

>>     The session name is reset to the default value stored in
>>     <literal>session.name</literal> at request startup time. Thus, you
>> need to
>>     call <function>session_name</function> for every request (and before

-- 
Christoph M. Becker

-- 
PHP Documentation Commits Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[prev in list] [next in list] [prev in thread] [next in thread]