[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-doc-cvs
Subject:    Re: [DOC-CVS] Re: svn: /phpdoc/en/trunk/reference/pcre/ pattern.modifiers.xml
From:       Maciek Sokolewicz <tularis () php ! net>
Date:       2017-03-27 9:15:53
Message-ID: 36d56a5a-1aad-ac90-2e5e-ab991d253334 () php ! net
[Download RAW message or body]

On 27-3-2017 11:00, Peter Cowburn wrote:
> On 27 March 2017 at 09:45, Maciek Sokolewicz <tularis@php.net> wrote:
>
>> Hm, this is more gender-neutral, that's true.
>>
>> However it is no longer grammatically correct. You're combining a singular
>> noun (the attacker) with a plural form (them).
>
>
> The change here (using "them" in the singular) is grammatically correct.

Sorry, you're correct, it is indeed grammatically correct (my bad), 
Rather it's a matter of style. The singular they (or them in this case) 
is gaining ground, and more people are using it these days. But it's 
still a bit controversial in many places, and many style guides by large 
publishers suggest trying to avoid its use. I personally believe 
avoiding would also be better. Somehow (to me) it still feels wrong. 
Hence my reply.


>> It would be better to change the wording to something like "and as such
>> would provide nearly complete access to the server" which completely gets
>> rid of any gender-ambiguity and is still grammatically correct.
>>
>> - Maciek
>>
>>
>> On 25-3-2017 13:23, Christoph Michael Becker wrote:
>>
>>> cmb                                      Sat, 25 Mar 2017 12:23:58 +0000
>>>
>>> Revision: http://svn.php.net/viewvc?view=revision&revision=342184
>>>
>>> Log:
>>> Gender neutral wording
>>>
>>> Patch provided by Tom Hudson.
>>>
>>> Changed paths:
>>>     U   phpdoc/en/trunk/reference/pcre/pattern.modifiers.xml
>>>
>>> Modified: phpdoc/en/trunk/reference/pcre/pattern.modifiers.xml
>>> ===================================================================
>>> --- phpdoc/en/trunk/reference/pcre/pattern.modifiers.xml
>>> 2017-03-25 12:23:02 UTC (rev 342183)
>>> +++ phpdoc/en/trunk/reference/pcre/pattern.modifiers.xml
>>> 2017-03-25 12:23:58 UTC (rev 342184)
>>> @@ -127,7 +127,7 @@
>>>          <para>
>>>           The above example code can be easily exploited by passing in a
>>> string such as
>>>           <literal>&lt;h1&gt;{${eval($_GET[php_code])}}&lt;/h1&gt;</literal>.
>>> This gives
>>> -         the attacker the ability to execute arbitrary PHP code and as
>>> such gives him
>>> +         the attacker the ability to execute arbitrary PHP code and as
>>> such gives them
>>>           nearly complete access to your server.
>>>          </para>
>>>          <para>
>>>
>>>
>>
>> ---
>> This email has been checked for viruses by Avast antivirus software.
>> https://www.avast.com/antivirus
>>
>>
>> --
>> PHP Documentation Commits Mailing List (http://www.php.net/)
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
>


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


-- 
PHP Documentation Commits Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[prev in list] [next in list] [prev in thread] [next in thread]