[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-doc-cvs
Subject:    Re: [DOC-CVS] svn: /phpdoc/en/trunk/reference/pthreads/threaded/ shift.xml
From:       Joe Watkins <pthreads () pthreads ! org>
Date:       2014-09-26 10:30:37
Message-ID: CAL=_i_nH+7UvoiJkzOgKMP20e_7JOEZJVOVrzqEw4U6siknWeQ () mail ! gmail ! com
[Download RAW message or body]


I would have, the doc editor must have done the whitespace fixes for me ...
all I did was open and change return type and commit ...

Cheers
Joe

On Fri, Sep 26, 2014 at 11:08 AM, Peter Cowburn <petercowburn@gmail.com>
wrote:

>
>
> On 26 September 2014 07:52, Joe Watkins <krakjoe@php.net> wrote:
>
>> krakjoe                                  Fri, 26 Sep 2014 06:52:55 +0000
>>
>> Revision: http://svn.php.net/viewvc?view=revision&revision=334983
>>
>> Log:
>> fix #66654 wrong return type
>>
>> Bug: https://bugs.php.net/66654 (Open) shift() method is documented to
>> return boolean. But returns item itself
>>
>> Changed paths:
>>     UU  phpdoc/en/trunk/reference/pthreads/threaded/shift.xml
>>
>
> Please, please be careful to separate out whitespace, SVN property, etc.
> changes into their own clearly labelled commits. The actual content change
> (return type) is buried under the whitespace changes from the svn:eol-style
> property change.
>
>
>>
>> Modified: phpdoc/en/trunk/reference/pthreads/threaded/shift.xml
>> ===================================================================
>> --- phpdoc/en/trunk/reference/pthreads/threaded/shift.xml
>>  2014-09-25 20:26:33 UTC (rev 334982)
>> +++ phpdoc/en/trunk/reference/pthreads/threaded/shift.xml
>>  2014-09-26 06:52:55 UTC (rev 334983)
>> @@ -1,75 +1,75 @@
>> -<?xml version="1.0" encoding="utf-8"?>
>> -<!-- $Revision$ -->
>> -
>> -<refentry xml:id="threaded.shift" xmlns="http://docbook.org/ns/docbook"
>> xmlns:xlink="http://www.w3.org/1999/xlink">
>> - <refnamediv>
>> -  <refname>Threaded::shift</refname>
>> -  <refpurpose>Manipulation</refpurpose>
>> - </refnamediv>
>> -
>> - <refsect1 role="description">
>> -  &reftitle.description;
>> -  <methodsynopsis>
>> -   <modifier>public</modifier>
>> <type>boolean</type><methodname>Threaded::shift</methodname>
>> -   <void />
>> -  </methodsynopsis>
>> -  <para>
>> -  Shifts an item from the objects property table
>> -  </para>
>> - </refsect1>
>> -
>> - <refsect1 role="returnvalues">
>> -  &reftitle.returnvalues;
>> -  <para>
>> -  The first item from the objects property table
>> -  </para>
>> - </refsect1>
>> -
>> - <refsect1 role="examples">
>> -  &reftitle.examples;
>> -  <para>
>> -   <example>
>> -    <title>Shifting the first item from the property table of a threaded
>> object</title>
>> -    <programlisting role="php">
>> -<![CDATA[
>> -<?php
>> -$safe = new Threaded();
>> -
>> -while (count($safe) < 10)
>> -    $safe[] = count($safe);
>> -
>> -var_dump($safe->shift());
>> -?>
>> -]]>
>> -    </programlisting>
>> -    &example.outputs;
>> -    <screen>
>> -<![CDATA[
>> -int(0)
>> -]]>
>> -    </screen>
>> -   </example>
>> -  </para>
>> - </refsect1>
>> -</refentry>
>> -
>> -<!-- Keep this comment at the end of the file
>> -Local variables:
>> -mode: sgml
>> -sgml-omittag:t
>> -sgml-shorttag:t
>> -sgml-minimize-attributes:nil
>> -sgml-always-quote-attributes:t
>> -sgml-indent-step:1
>> -sgml-indent-data:t
>> -indent-tabs-mode:nil
>> -sgml-parent-document:nil
>> -sgml-default-dtd-file:"~/.phpdoc/manual.ced"
>> -sgml-exposed-tags:nil
>> -sgml-local-catalogs:nil
>> -sgml-local-ecat-files:nil
>> -End:
>> -vim600: syn=xml fen fdm=syntax fdl=2 si
>> -vim: et tw=78 syn=sgml
>> -vi: ts=1 sw=1
>> --->
>> +<?xml version="1.0" encoding="utf-8"?>
>> +<!-- $Revision$ -->
>> +
>> +<refentry xml:id="threaded.shift" xmlns="http://docbook.org/ns/docbook"
>> xmlns:xlink="http://www.w3.org/1999/xlink">
>> + <refnamediv>
>> +  <refname>Threaded::shift</refname>
>> +  <refpurpose>Manipulation</refpurpose>
>> + </refnamediv>
>> +
>> + <refsect1 role="description">
>> +  &reftitle.description;
>> +  <methodsynopsis>
>> +   <modifier>public</modifier>
>> <type>mixed</type><methodname>Threaded::shift</methodname>
>> +   <void />
>> +  </methodsynopsis>
>> +  <para>
>> +  Shifts an item from the objects property table
>> +  </para>
>> + </refsect1>
>> +
>> + <refsect1 role="returnvalues">
>> +  &reftitle.returnvalues;
>> +  <para>
>> +  The first item from the objects property table
>> +  </para>
>> + </refsect1>
>> +
>> + <refsect1 role="examples">
>> +  &reftitle.examples;
>> +  <para>
>> +   <example>
>> +    <title>Shifting the first item from the property table of a threaded
>> object</title>
>> +    <programlisting role="php">
>> +<![CDATA[
>> +<?php
>> +$safe = new Threaded();
>> +
>> +while (count($safe) < 10)
>> +    $safe[] = count($safe);
>> +
>> +var_dump($safe->shift());
>> +?>
>> +]]>
>> +    </programlisting>
>> +    &example.outputs;
>> +    <screen>
>> +<![CDATA[
>> +int(0)
>> +]]>
>> +    </screen>
>> +   </example>
>> +  </para>
>> + </refsect1>
>> +</refentry>
>> +
>> +<!-- Keep this comment at the end of the file
>> +Local variables:
>> +mode: sgml
>> +sgml-omittag:t
>> +sgml-shorttag:t
>> +sgml-minimize-attributes:nil
>> +sgml-always-quote-attributes:t
>> +sgml-indent-step:1
>> +sgml-indent-data:t
>> +indent-tabs-mode:nil
>> +sgml-parent-document:nil
>> +sgml-default-dtd-file:"~/.phpdoc/manual.ced"
>> +sgml-exposed-tags:nil
>> +sgml-local-catalogs:nil
>> +sgml-local-ecat-files:nil
>> +End:
>> +vim600: syn=xml fen fdm=syntax fdl=2 si
>> +vim: et tw=78 syn=sgml
>> +vi: ts=1 sw=1
>> +-->
>>
>>
>> Property changes on: phpdoc/en/trunk/reference/pthreads/threaded/shift.xml
>> ___________________________________________________________________
>> Added: svn:eol-style
>>    + native
>>
>>
>> --
>> PHP Documentation Commits Mailing List (http://www.php.net/)
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>
>


[prev in list] [next in list] [prev in thread] [next in thread]