[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-doc-cvs
Subject:    Re: [DOC-CVS] svn: /phpdoc/en/trunk/reference/session/ examples.xml
From:       Sherif Ramadan <theanomaly.is () gmail ! com>
Date:       2013-01-25 8:12:58
Message-ID: CAL+t6cHrxtPzpjz4RqYOowmDeyBKSKB+xoObwep9KVQvFbg0NQ () mail ! gmail ! com
[Download RAW message or body]


On Fri, Jan 25, 2013 at 2:37 AM, Joe Watkins <krakjoe@php.net> wrote:

> krakjoe                                  Fri, 25 Jan 2013 07:37:46 +0000
>
> Revision: http://svn.php.net/viewvc?view=revision&revision=329295
>
> Log:
> in response to bug #64058, a warning is apparently appropriate
>
> Bug: https://bugs.php.net/64058 (Closed) Warn about register_globals
>
> Changed paths:
>     U   phpdoc/en/trunk/reference/session/examples.xml
>
> Modified: phpdoc/en/trunk/reference/session/examples.xml
> ===================================================================
> --- phpdoc/en/trunk/reference/session/examples.xml      2013-01-25
> 06:25:23 UTC (rev 329294)
> +++ phpdoc/en/trunk/reference/session/examples.xml      2013-01-25
> 07:37:46 UTC (rev 329295)
> @@ -83,6 +83,11 @@
>      to restore a reference to another variable.
>     </para>
>    </warning>
> +  <warning>
> +   <para>
> +    If register_globals is set ON, then any key you use in $_SESSION will
> be a reference to a global variable of the same name. This will cause your
> session variables to change if you use a key that matches the name of a
> global variable.
> +   </para>
> +  </warning>
>   </section>
>
>   <section xml:id="session.idpassing">
>
>
> --
> PHP Documentation Commits Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>


This is incorrect. register_globals does not create references. The use of
the word "reference" here needs to be carefully phrased. Link to the
register_globals documentation instead as we already document how it
affects $_SESSION.

The user is confusing deprecated session_register behavior (which does
create references) with register_globals behavior, which does not.

See documentation http://php.net/manual/en/function.session-register.php
and code http://lxr.php.net/xref/PHP_5_2/ext/session/session.c#170


[prev in list] [next in list] [prev in thread] [next in thread]