[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-doc-cvs
Subject:    Re: [DOC-CVS] svn: /phd/trunk/ package.xml package_generic.xml
From:       Hannes Magnusson <hannes.magnusson () gmail ! com>
Date:       2009-10-30 18:07:06
Message-ID: 7f3ed2c30910301107l86c98a7yb97071773d3d7127 () mail ! gmail ! com
[Download RAW message or body]

2009/10/30 Hannes Magnusson <hannes.magnusson@gmail.com>:
> 
> 
> 2009/10/29 Richard Quadling <rquadling@php.net>:
> > rquadling                                Thu, 29 Oct 2009 11:04:46 +0000
> > 
> > Revision: http://svn.php.net/viewvc?view=revision&revision=290052
> > 
> > Log:
> > Added VERBOSE_MISSING_ATTRIBUTES verbose level
> > Separated PhD verbose messages into informational and warnings
> > PhD verbose warning messages are coloured magenta
> > Added MediaManger->findFile() method to return full filename of required image
> > VERBOSE_MISSING_ATTRIBUTE message generated when missing one of the width/height \
> > attributes on imagedata VERBOSE_MISSING_ATTRIBUTE message generated when missing \
> > alt attributes on mediaobject > imagedata 
> 
> Kudos.
> 
> Maybe add VERBOSE_ERROR, VERBOSE_WARNING and VERBOSE_INFO constants? Would make it \
> easier to only suppress/retrieve those specific messages.. 

Also, this is hard to read:
+                v('Missing ' . (!$width ? 'width' : 'height') . '
attribute for ' . $file, VERBOSE_MISSING_ATTRIBUTES);

v() supports variable arguments al'a printf()...

-Hannes

-- 
PHP Documentation Commits Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php


[prev in list] [next in list] [prev in thread] [next in thread]