[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-cvs
Subject:    [PHP-CVS] com php-src: Fix typo in compound dim assign op inference: =?UTF-8?Q?ext/opcache/Optimizer
From:       Nikita Popov <nikic () php ! net>
Date:       2018-06-30 17:50:07
Message-ID: php-mail-7072a747b3c8cd1790779ba993b2d14a1035470071 () git ! php ! net
[Download RAW message or body]

Commit:    2eb6a541a9d4141dcad427799cf8acbeba3f2777
Author:    Nikita Popov <nikita.ppv@gmail.com>         Sat, 30 Jun 2018 19:49:29 +0200
Parents:   ae04110032702622d59c21f9e615120d9479157a
Branches:  PHP-7.1 PHP-7.2 master

Link:       http://git.php.net/?p=php-src.git;a=commitdiff;h=2eb6a541a9d4141dcad427799cf8acbeba3f2777

Log:
Fix typo in compound dim assign op inference

Thankfully a harmless one, just makes inference results worse.

Changed paths:
  M  ext/opcache/Optimizer/zend_inference.c


Diff:
diff --git a/ext/opcache/Optimizer/zend_inference.c b/ext/opcache/Optimizer/zend_inference.c
index 9f930a1..92813ec 100644
--- a/ext/opcache/Optimizer/zend_inference.c
+++ b/ext/opcache/Optimizer/zend_inference.c
@@ -2372,7 +2372,7 @@ static int zend_update_type_info(const zend_op_array *op_array,
 
 			if (opline->extended_value == ZEND_ASSIGN_DIM) {
 				if (opline->op1_type == IS_CV) {
-					orig = assign_dim_result_type(orig, OP2_INFO(), tmp, opline->op1_type);
+					orig = assign_dim_result_type(orig, OP2_INFO(), tmp, opline->op2_type);
 					UPDATE_SSA_TYPE(orig, ssa_ops[i].op1_def);
 					COPY_SSA_OBJ_TYPE(ssa_ops[i].op1_use, ssa_ops[i].op1_def);
 				}


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[prev in list] [next in list] [prev in thread] [next in thread]