[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-cvs
Subject:    [PHP-CVS] com php-src: Return null instead of false: =?UTF-8?Q?ext/date/php=5Fdate?= =?UTF-8?Q?=2Ec?
From:       Aaron Piotrowski <trowski () php ! net>
Date:       2016-06-29 15:02:17
Message-ID: php-mail-48614d5ea432601e3c85bfb08723b79e299209368 () git ! php ! net
[Download RAW message or body]

Commit:    9638e45d2f4cf0bb63e5189fccacbd624cba37be
Author:    Aaron Piotrowski <aaron@trowski.com>         Wed, 29 Jun 2016 10:02:17 -0500
Parents:   e4b1bfc0757447b1b53adfb61d15e367e96f6a4d
Branches:  master

Link:       http://git.php.net/?p=php-src.git;a=commitdiff;h=9638e45d2f4cf0bb63e5189fccacbd624cba37be

Log:
Return null instead of false

Changed paths:
  M  ext/date/php_date.c


Diff:
diff --git a/ext/date/php_date.c b/ext/date/php_date.c
index e76ca7f..99fa6c0 100644
--- a/ext/date/php_date.c
+++ b/ext/date/php_date.c
@@ -3697,7 +3697,7 @@ PHP_METHOD(DateTimeZone, __set_state)
 	HashTable        *myht;
 
 	if (zend_parse_parameters(ZEND_NUM_ARGS(), "a", &array) == FAILURE) {
-		RETURN_FALSE;
+		return;
 	}
 
 	myht = Z_ARRVAL_P(array);
@@ -3707,7 +3707,6 @@ PHP_METHOD(DateTimeZone, __set_state)
 	if(php_date_timezone_initialize_from_hash(&return_value, &tzobj, myht) != SUCCESS) {
 		zend_throw_error(NULL, "Timezone initialization failed");
 		zval_dtor(return_value);
-		RETURN_FALSE;
 	}
 }
 /* }}} */
@@ -3726,7 +3725,6 @@ PHP_METHOD(DateTimeZone, __wakeup)
 
 	if(php_date_timezone_initialize_from_hash(&return_value, &tzobj, myht) != SUCCESS) {
 		zend_throw_error(NULL, "Timezone initialization failed");
-		RETURN_FALSE;
 	}
 }
 /* }}} */


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[prev in list] [next in list] [prev in thread] [next in thread]