[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-cvs
Subject:    Re: [PHP-CVS] com php-src: More type inferences fixes: ext/opcache/Optimizer/zend_func_info.c ext/op
From:       Nikita Popov <nikita.ppv () gmail ! com>
Date:       2016-06-28 16:51:37
Message-ID: CAF+90c8YfJmG2buqVPZVM6N0n8SaZ5y5dcD4SFQvGGQE_Org-w () mail ! gmail ! com
[Download RAW message or body]


On Tue, Jun 28, 2016 at 6:28 PM, Dmitry Stogov <dmitry@zend.com> wrote:

> Hi Nikita,
>
>
> it looks like you broke something.
>
>
> $ USE_ZEND_ALLOC=0 valgrind sapi/cgi/php-cgi
> /var/www/html/bench/wordpress-4.2.2/index.php
>
>
> ==2162== Invalid read of size 4
> ==2162==    at 0x7B859B8: zend_update_type_info (zend_inference.c:3322)
> ==2162==    by 0x7B859B8: zend_infer_types_ex (zend_inference.c:3526)
> ==2162==    by 0x7B8B764: zend_infer_types (zend_inference.c:4003)
> ==2162==    by 0x7B8B91E: zend_ssa_inference (zend_inference.c:4062)
> ==2162==    by 0x7B73368: zend_dfa_analyze_op_array (dfa_pass.c:106)
> ==2162==    by 0x7B68700: zend_optimize_script (zend_optimizer.c:912)
> ==2162==    by 0x7B598EC: cache_script_in_shared_memory
> (ZendAccelerator.c:1256)
> ==2162==    by 0x7B598EC: persistent_compile_file (ZendAccelerator.c:1834)
> ==2162==    by 0x845AC34: compile_filename (zend_language_scanner.l:656)
> ==2162==    by 0x84EA8A9: zend_include_or_eval (zend_execute.c:2827)
> ==2162==    by 0x8522B95: ZEND_INCLUDE_OR_EVAL_SPEC_TMPVAR_HANDLER
> (zend_vm_execute.h:51060)
> ==2162==    by 0x84D24A1: execute_ex (zend_vm_execute.h:429)
> ==2162==    by 0x8526117: zend_execute (zend_vm_execute.h:474)
> ==2162==    by 0x849030C: zend_execute_scripts (zend.c:1441)
> ==2162==  Address 0x5eb41114 is not stack'd, malloc'd or (recently) free'd
> ==2162==
>
>
> This worked few commits before.
>
Thanks. I've dropped the assert for now, clearly not all opcodes covered
there yet.

Nikita


[prev in list] [next in list] [prev in thread] [next in thread]