[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-cvs
Subject:    Re: [PHP-CVS] cvs: php-src /ext/gd gd.c
From:       "Nuno Lopes" <nlopess () php ! net>
Date:       2008-02-28 20:08:08
Message-ID: 1766BB897EDA49EA933000CB9AB4BB4B () pc07654
[Download RAW message or body]

> felipe Thu Feb 28 17:43:32 2008 UTC
>
>  Modified files:
>    /php-src/ext/gd gd.c
>  Log:
>  Fixed return value changed previously
>
> http://cvs.php.net/viewvc.cgi/php-src/ext/gd/gd.c?r1=1.384&r2=1.385&diff_format=u
> Index: php-src/ext/gd/gd.c
> diff -u php-src/ext/gd/gd.c:1.384 php-src/ext/gd/gd.c:1.385
> --- php-src/ext/gd/gd.c:1.384 Thu Feb 28 14:16:12 2008
> +++ php-src/ext/gd/gd.c Thu Feb 28 17:43:32 2008
> @@ -1351,7 +1351,7 @@
> PHP_FUNCTION(gd_info)
> {
>  if (zend_parse_parameters_none() == FAILURE) {
> - return;
> + RETURN_FALSE;
>  }


You can leave the 'return;' there, as it's current practice to return NULL 
when it fails the parameter validation. You may have to tune some tests, 
though.
Nuno 

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[prev in list] [next in list] [prev in thread] [next in thread]