[prev in list] [next in list] [prev in thread] [next in thread] 

List:       php-cvs
Subject:    Re: [PHP-CVS] cvs: php-src /ext/fbsql php_fbsql.c php_fbsql.h
From:       Andi Gutmans <andi () zend ! com>
Date:       2004-02-27 8:43:14
Message-ID: 5.1.0.14.2.20040227104224.02c45420 () 127 ! 0 ! 0 ! 1
[Download RAW message or body]

Yep, we really shouldn't be adding new features.
However, fbsql is pretty isolated and so is the patch so I think it's OK.
I really don't like the following piece of code though:
digest = emalloc(17);
Is it possible to use some #define or sizeof("foobar") so that it is clear 
what 17 means?

Thanks Jan.

Andi

At 00:26 27/02/2004 +0100, Jan Lehnardt wrote:
>Hi,
>On 26 Feb 2004, at 21:31, Frank M. Kromann wrote:
>>fmk             Thu Feb 26 15:31:15 2004 EDT
>>
>>   Modified files:
>>     /php-src/ext/fbsql  php_fbsql.c php_fbsql.h
>>   Log:
>>   Adding function to change user passwords
>
>bugfix-only-and-feature-freeze-please-check-with-andi-alert.
>
>Jan
>--
>
>--
>PHP CVS Mailing List (http://www.php.net/)
>To unsubscribe, visit: http://www.php.net/unsub.php

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[prev in list] [next in list] [prev in thread] [next in thread]