[prev in list] [next in list] [prev in thread] [next in thread] 

List:       phorum-dev
Subject:    [phorum-dev] [localization] Search page & 3.1.1pre, [html] some basic
From:       Paul Guyot <pguyot () pnm-consulting ! com>
Date:       2000-05-31 12:00:06
[Download RAW message or body]

Hi folks,

There are two problems with localization.
The first one is simply that the localization files hasn't been 
updated for the mark all read new feature in 3.1.1pre.

The second one is the search.php form.

Here are the changes:
All Words	-><?PHP echo $lSearchAllWords;?>
Any Word -> <?PHP echo $lSearchAnyWord;?>
Exact Phrase -> <?PHP echo $lSearchExactPhrase;?>
Last 30 Days -> <?PHP echo $lSearchLast30days;?>
Last 60 Days -> <?PHP echo $lSearchLast60days;?>
Last 90 Days -> <?PHP echo $lSearchLast90days;?>
Last 180 Days -> <?PHP echo $lSearchLast180days;?>
All Dates -> <?PHP echo $lSearchAllDates;?>

All this happens line 292.
Here is the suggestion for the new line:
     <td><font color="<?PHP echo $ForumTableBodyFontColor2; 
?>"><select name="match"><option value="1" <?PHP if($match==1) echo 
"selected"; ?>><?PHP echo $lSearchAllWords;?></option><option 
value="2" <?PHP if($match==2) echo "selected"; ?>><?PHP echo 
$lSearchAnyWord;?></option><option value="3" <?PHP if($match==3) echo 
"selected"; ?>><?PHP echo 
$lSearchExactPhrase;?></option></select>&nbsp;&nbsp;&nbsp;&nbsp;<select 
name="date"><option value="30" <?PHP if($date==30) echo "selected"; 
?>><?PHP echo $lSearchLast30days;?></option><option value="60" <?PHP 
if($date==60) echo "selected"; ?>><?PHP echo 
$lSearchLast60days;?></option><option value="90" <?PHP if($date==90) 
echo "selected"; ?>><?PHP echo $lSearchLast90days;?></option><option 
value="180" <?PHP if($date==180) echo "selected"; ?>><?PHP echo 
$lSearchLast180days;?></option><option value="0" <?PHP if($date==0) 
echo "selected"; ?>><?PHP echo 
$lSearchAllDates;?></option></select></font></td>

(it could be optimized by merging
<?PHP if($date==0) echo "selected"; ?>><?PHP echo $lSearchAllDates;?> 
& other parts like this one)

Additionally, line 287:
Search -> <?PHP echo $lSearch;?>

You guessed the new entries in english.php

In french.php, a suggestion:
   $lMarkRead        = "Les marquer tous lus";

   $lSearchAllWords  = "Tous les mots";
   $lSearchAnyWord   = "Au moins un des mots";
   $lSearchExactPhrase  = "Phrase";
   $lSearchLast30days   = "Derniers 30 jours";
   $lSearchLast60days   = "Derniers 60 jours";
   $lSearchLast90days   = "Derniers 90 jours";
   $lSearchLast180days  = "Derniers 180 jours";
   $lSearchAllDates  = "Tous les messages";

The HTML generated code suffer from some problems.
a/ div elements: the class attribute is better within quotes:
<div class=nav> -> <div class="nav"> (or <div class=\"nav\"> if 
inside a var definition)
b/ navigation bar: (search.php only)
   if($ActiveForums>1){
     $nav = "<div class="nav"><a 
href=\"$forum_page.$ext?f=$ForumParent$GetVars\"><font 
color='$ForumNavFontColor'>".$lForumList."</font></a>&nbsp;&nbsp;|&nbsp;&nbsp;<a 
href=\"$post_page.$ext?f=$num$GetVars\"><font 
color='$ForumNavFontColor'>".$lStartTopic."</font></a>&nbsp;&nbsp;|&nbsp;&nbsp;<a 
href=\"$list_page.$ext?f=$num$GetVars\"><font 
color='$ForumNavFontColor'>".$lGoToTop."</font></a>&nbsp;</font></div>";
   }
   else{
     $nav = "<div class="nav"><font color='$ForumNavFontColor'><a 
href=\"$post_page.$ext?f=$num$GetVars\"><font 
color='$ForumNavFontColor'>".$lStartTopic."</font></a>&nbsp;&nbsp;|&nbsp;&nbsp;<a 
href=\"$list_page.$ext?f=$num$GetVars\"><font 
color='$ForumNavFontColor'>".$lGoToTop."</font></a>&nbsp;</font></div>";
   }

There is a missing font at the beginning of the first nav definition.

c/ Search.php, Line 299
</font><br></td>

It should be deleted.

d/ td's width parameter cannot have relative values
In the following files, this parameter is 100%. It is therefore 
useless, and should be deleted:
File "down.php"; Line 34
File "index.php"; Line 63
File "index.php"; Line 133
File "read.php"; Line 274
File "read.php"; Line 330
File "read.php"; Line 371
File "include/form.php"; Line 93
File "include/form.php"; Line 97
File "include/form.php"; Line 101
File "include/multi-threads.php"; Line 186
File "include/threads.php"; Line 8

e/ In links, & should be written &amp;
File "common.php"; Line 95

File "list.php"; Line 202
File "list.php"; Line 205
File "list.php"; Line 209 (there is another bug there: in the nav, 
there is an extra useless &nbsp;</font>)
File "list.php"; Line 212
File "list.php"; Line 217
File "list.php"; Line 220
File "post.php"; Line 24
File "read.php"; Line 159
File "read.php"; Line 160
File "read.php"; Line 170
File "read.php"; Line 179
File "read.php"; Line 246
File "read.php"; Line 249
File "search.php"; Line 232
File "search.php"; Line 251
File "search.php"; Line 254

File "admin/header.php"; Line 89
File "admin/pages/easyadmin.php"; Line 48
File "admin/pages/easyadmin.php"; Line 49
File "admin/pages/easyadmin.php"; Line 63
File "admin/pages/easyadmin.php"; Line 253
File "admin/pages/manage.php"; Line 4
File "admin/pages/manage.php"; Line 38
File "admin/pages/managemenu.php"; Line 33
File "admin/pages/managemenu.php"; Line 34
File "admin/pages/managemenu.php"; Line 35
File "admin/pages/managemenu.php"; Line 36
File "admin/pages/managemenu.php"; Line 37
File "admin/pages/managemenu.php"; Line 38
File "admin/pages/managemenu.php"; Line 40
File "admin/pages/managemenu.php"; Line 42
File "admin/pages/managemenu.php"; Line 44
File "admin/pages/managemenu.php"; Line 47
File "admin/pages/managemenu.php"; Line 49

File "include/multi-threads.php"; Line 46
File "include/multi-threads.php"; Line 47
File "include/threads.php"; Line 66

Regards,

Paul
-- 
P&M Consulting Newton Program
http://www.pnm-consulting.com/newton/

---------------------------------------------------------------------
To unsubscribe, e-mail: phorum-dev-unsubscribe@lists.phorum.org
For additional commands, e-mail: phorum-dev-help@lists.phorum.org

[prev in list] [next in list] [prev in thread] [next in thread]