[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-patches
Subject:    Re: [PATCHES] Simplify formatting.c
From:       Tom Lane <tgl () sss ! pgh ! pa ! us>
Date:       2008-05-20 23:09:37
Message-ID: 7221.1211324977 () sss ! pgh ! pa ! us
[Download RAW message or body]

Euler Taveira de Oliveira <euler@timbira.com> writes:
> Tom Lane wrote:
>> Also, it seems a bit inconsistent to be relying on
>> oracle_compat.c for upper/lower but not initcap.
>> 
> I saw this inconsistence while I'm doing the patch. What about moving 
> that upper/lower/initcap and wcs* code to another file. pg_locale.c? 

That doesn't seem a particularly appropriate place for them.  pg_locale
is about dealing with the locale state, not about doing actual
operations based on the locale data.

I was just thinking of having oracle_compat expose an initcap routine.

			regards, tom lane

-- 
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches
[prev in list] [next in list] [prev in thread] [next in thread]