[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-patches
Subject:    Re: [pgsql-patches] [HACKERS] [BUGS] BUG #2907: pg_get_serial_sequence quoting
From:       Adriaan van Os <postgres () microbizz ! nl>
Date:       2007-01-30 15:10:07
Message-ID: 45BF5FCF.1080708 () microbizz ! nl
[Download RAW message or body]

Bruce Momjian wrote:
> Adriaan van Os wrote:
>> Tom Lane wrote:
>>> Bruce Momjian <bruce@momjian.us> writes:
>>>>> I presume the reason for that is that the first paramater can be
>>>>> qualified:
>>>>> select pg_get_serial_sequence('"public"."FOO"', 'Ff1');
>>>> Would someone explain why qualification makes us lowercase the first
>>>> parameter by default?  I don't understand it well enough to document it.
>>> The point is that we have to parse the first parameter, whereas the
>>> second one can be taken literally.
>> It still looks inconsistent and ugly. I think the design mistake of pg_get_serial_sequence is that 
>> it takes two parameters rather than one (a fully qualified doublequoted columnname path) or three 
>> (optionally empty schema, tablename, columnname, all three literal).
> 
> I did my best to document the behavior of pg_get_serial_sequence(). 
> There actually is a technical reason why we can't auto-quote the first
> parameter.  Patch applied to HEAD and 8.2.X.

Thanks for the doc change.

Adriaan van Os

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

               http://www.postgresql.org/docs/faq

[prev in list] [next in list] [prev in thread] [next in thread]