[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-hackers
Subject:    Re: [PATCH] minor reloption regression tests improvement
From:       Jacob Champion <jchampion () timescale ! com>
Date:       2022-06-30 23:16:24
Message-ID: CAAWbhmiuRnNo1Xfd2VvbK0-3YrU7bCwnHXTSOpnLiWd9+5cMnA () mail ! gmail ! com
[Download RAW message or body]

On Wed, Jun 29, 2022 at 9:04 PM Nikolay Shaplov <dhyan@nataraj.su> wrote:
> =D0=92 =D0=BF=D0=B8=D1=81=D1=8C=D0=BC=D0=B5 =D0=BE=D1=82 =D1=87=D0=B5=D1=
=82=D0=B2=D0=B5=D1=80=D0=B3, 30 =D0=B8=D1=8E=D0=BD=D1=8F 2022 =D0=B3. 06:47=
:48 MSK =D0=BF=D0=BE=D0=BB=D1=8C=D0=B7=D0=BE=D0=B2=D0=B0=D1=82=D0=B5=D0=BB=
=D1=8C Nikolay Shaplov
> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB:
>
> > Hi! I am surely feel this patch is important. I have bigger patch
> > https://commitfest.postgresql.org/38/3536/ and this test makes sense as=
 a
> > part of big work of options refactoring,
> >
> > I am also was strongly advised to commit things chopped into smaller pa=
rts,
> > when possible. This test can be commit separately so I am doing it.
>
> Let me again explain why this test is importaint, so potential reviewers =
can
> easily find this information.
>
> Tests are for developers. You change the code and see that something does=
 not
> work anymore, as it worked before.
> When you change the code, you should keep both documented and undocumente=
d
> behaviour. Because user's code can intentionally  or accidentally use it.

[developer hat] Right, but I think Greg also pointed out the tradeoff
here, and my understanding was that he didn't feel that the tradeoff
was enough. If this is related to a bigger refactoring, it may be
easier to argue the test's value if it's discussed there? (This could
be frustrating if you've just been told to split things up, sorry.)

[CFM hat] Since you feel strongly about the patch, and we're short on
time before the commitfest starts, I have re-registered this. That way
there can be an explicit decision as opposed to a pocket veto by me.

    https://commitfest.postgresql.org/38/3747/

Thanks,
--Jacob


[prev in list] [next in list] [prev in thread] [next in thread]