[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-hackers
Subject:    Re: Opclass parameters of indexes lost after REINDEX CONCURRENTLY
From:       Michael Paquier <michael () paquier ! xyz>
Date:       2021-10-30 12:26:35
Message-ID: YX05++bLtwyfaOle () paquier ! xyz
[Download RAW message or body]


On Sat, Oct 30, 2021 at 04:11:06AM -0700, Zhihong Yu wrote:
> Should datumCopy() be used inside the loop ? I saw the following
> in get_attoptions(Oid relid, int16 attnum):

Yeah, you are right that it would be better here to use
get_attoptions() to grab a copy of each attribute's option directly
from the catalogs.  We also do that for predicates and expressions.
--
Michael

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]