[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-hackers
Subject:    Re: Documentation patch for backup manifests in protocol.sgml
From:       Bruce Momjian <bruce () momjian ! us>
Date:       2020-08-31 22:48:53
Message-ID: 20200831224853.GT13613 () momjian ! us
[Download RAW message or body]

On Mon, Aug 24, 2020 at 04:58:34PM +0900, Michael Paquier wrote:
> On Fri, Aug 21, 2020 at 06:03:32PM -0400, Bruce Momjian wrote:
> > On Tue, Aug 18, 2020 at 02:41:09PM +0200, Bernd Helmle wrote:
> >> protocol.sgml describes the protocol messages received by a BASE_BACKUP
> >> streaming command, but doesn't tell anything about the additional
> >> CopyResponse data message containing the contents of the backup
> >> manifest (if requested) after having received the tar files. So i
> >> propose the attached to give a little more detail in this paragraph.
> > 
> > If someone can confirm this, I will apply it?  Magnus?
> 
> The reason why backup manifests are sent at the end of a base backup
> is that they include the start and stop positions of the backup (see
> caller of AddWALInfoToBackupManifest() in perform_base_backup()).
> Once this is done, an extra CopyOutResponse message is indeed sent
> within SendBackupManifest() in backup_manifest.c.
> 
> So confirmed.

Patch applied through 13.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee



[prev in list] [next in list] [prev in thread] [next in thread]