[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-hackers
Subject:    [HACKERS] Duplicate prototype for socket_set_nonblocking.
From:       Kyotaro HORIGUCHI <horiguchi.kyotaro () lab ! ntt ! co ! jp>
Date:       2016-07-29 1:12:22
Message-ID: 20160729.101222.123691412.horiguchi.kyotaro () lab ! ntt ! co ! jp
[Download RAW message or body]

Hello,

Looking into pqcomm.c, I noticed that the prototype of
socket_set_nonblocking defined twice. Actually the prototype is
not necessary at all but one may remain as a convention.

It doesn't no harm so backpatching seems unnecessary. 

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

["0001-Remove-duplicate-prototype-definition-for-socket_set.patch" (Text/X-Patch)]

From fa8911cbab690c8dc2f8b0d8864dee5470730bbe Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi <horiguchi.kyotaro@lab.ntt.co.jp>
Date: Fri, 29 Jul 2016 10:01:53 +0900
Subject: [PATCH] Remove duplicate prototype definition for
 socket_set_nonblocking.

---
 src/backend/libpq/pqcomm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/backend/libpq/pqcomm.c b/src/backend/libpq/pqcomm.c
index ba42753..90b6946 100644
--- a/src/backend/libpq/pqcomm.c
+++ b/src/backend/libpq/pqcomm.c
@@ -145,7 +145,6 @@ static void socket_startcopyout(void);
 static void socket_endcopyout(bool errorAbort);
 static int	internal_putbytes(const char *s, size_t len);
 static int	internal_flush(void);
-static void socket_set_nonblocking(bool nonblocking);
 
 #ifdef HAVE_UNIX_SOCKETS
 static int	Lock_AF_UNIX(char *unixSocketDir, char *unixSocketPath);
-- 
1.8.3.1



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[prev in list] [next in list] [prev in thread] [next in thread]