[prev in list] [next in list] [prev in thread] [next in thread] 

List:       pgsql-hackers
Subject:    Re: [HACKERS] Word-smithing doc changes
From:       Greg Stark <stark () mit ! edu>
Date:       2011-11-30 18:20:18
Message-ID: CAM-w4HPnN=7QyhdkEOpZ+hBGi4sHGv-N6L+OCvGWEHVqQPUTdg () mail ! gmail ! com
[Download RAW message or body]

On Wed, Nov 30, 2011 at 8:02 AM, Greg Smith <greg@2ndquadrant.com> wrote:
>>>> Except in the sections talking about locking
>>>> internals we don't talk about "shared locks on virtual transactions
>>>> identifiers" we just talk about waiting for a transaction to complete.

> What I cannot agree with is that idea that the implementation details I
> suggested documenting should not be.

What I'm suggesting is translating things like "shared locks on
virtual transaction identifiers" into what that means for users.
Namely saying something like "waiting for a transaction to complete".

Given your confusion it's clear that we have to explain that it will
wait one by one for each transaction that was started before the index
was created to finish. I don't think we need to explain how that's
implemented. If we do it should be set aside in some way, something
like "(see virtual transaction id locks in <href...>)".

I just want to keep in mind that the reader here is trying to
understand how to use create index concurrently, not understand how
Postgres's locking infrastructure works in general.



-- 
greg

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
[prev in list] [next in list] [prev in thread] [next in thread]